Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754371Ab3CKTbh (ORCPT ); Mon, 11 Mar 2013 15:31:37 -0400 Received: from hqemgate03.nvidia.com ([216.228.121.140]:3799 "EHLO hqemgate03.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754332Ab3CKTbf (ORCPT ); Mon, 11 Mar 2013 15:31:35 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Mon, 11 Mar 2013 12:31:33 -0700 Message-ID: <513E30A5.8020104@nvidia.com> Date: Tue, 12 Mar 2013 00:59:41 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 MIME-Version: 1.0 To: Stephen Warren CC: "akpm@linux-foundation.org" , "a.zummo@towertech.it" , "rtc-linux@googlegroups.com" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 3/5] rtc: tegra: use module_platform_driver_probe for module init/exit References: <1362852588-13362-1-git-send-email-ldewangan@nvidia.com> <1362852588-13362-4-git-send-email-ldewangan@nvidia.com> <513E1153.20207@wwwdotorg.org> In-Reply-To: <513E1153.20207@wwwdotorg.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1705 Lines: 47 On Monday 11 March 2013 10:46 PM, Stephen Warren wrote: > On 03/09/2013 11:09 AM, Laxman Dewangan wrote: >> Use macro module_platform_driver_probe() to reduce some of the >> boilerplate code in the driver. >> >> Signed-off-by: Laxman Dewangan >> --- >> drivers/rtc/rtc-tegra.c | 12 +----------- >> 1 files changed, 1 insertions(+), 11 deletions(-) >> >> diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c >> index f7718de..4cba10d 100644 >> --- a/drivers/rtc/rtc-tegra.c >> +++ b/drivers/rtc/rtc-tegra.c >> @@ -451,17 +451,7 @@ static struct platform_driver tegra_rtc_driver = { >> }, >> }; >> >> -static int __init tegra_rtc_init(void) >> -{ >> - return platform_driver_probe(&tegra_rtc_driver, tegra_rtc_probe); >> -} >> -module_init(tegra_rtc_init); >> - >> -static void __exit tegra_rtc_exit(void) >> -{ >> - platform_driver_unregister(&tegra_rtc_driver); >> -} >> -module_exit(tegra_rtc_exit); >> +module_platform_driver_probe(tegra_rtc_driver, tegra_rtc_probe); > Out of curiosity here, why not just module_platform_driver(); can't the > instantiation of the RTC device be driven by the presence of the DT > node, and hence the creation of the platform device object, just like > any other driver/device? Theoretically it should work but I will work with John (original author) about using the platform_driver_probe(). If he agrees then I will send patch to convert it to module_platform_driver(). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/