Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754635Ab3CKVNd (ORCPT ); Mon, 11 Mar 2013 17:13:33 -0400 Received: from mga09.intel.com ([134.134.136.24]:30667 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754011Ab3CKVNc (ORCPT ); Mon, 11 Mar 2013 17:13:32 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,825,1355126400"; d="scan'208";a="276712476" Date: Mon, 11 Mar 2013 21:13:26 +0000 From: Chris Wilson To: Kees Cook Cc: LKML , Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/i915: clarify reasoning for the access_ok call Message-ID: <20130311211326.GC31324@cantiga.alporthouse.com> Mail-Followup-To: Chris Wilson , Kees Cook , LKML , Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org References: <20130311192630.GA18227@www.outflux.net> <20130311205125.GA31324@cantiga.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 796 Lines: 21 On Mon, Mar 11, 2013 at 02:04:51PM -0700, Kees Cook wrote: > Probably not. It just seemed like the existing comment was > insufficient after the removal of the redundant VERIFY_READ check that > happened recently. That's certainly true, the remaining comment is a little cryptic. Something more like: /* We need to check that we can read the entire relocation array, but * as we may need to update the presumed_offsets upon execution, we * need to check now for full write access. */ -Chris -- Chris Wilson, Intel Open Source Technology Centre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/