Message-ID: <1363036774.2056.59.camel@joe-AO722>
Subject: Re: [PATCH] drivers: gpu: drm: i915: Replaced calls to kmalloc &
 memcpy with kmemdup
From: Joe Perches <joe@perches.com>
To: Alexandru Gheorghiu <gheorghiuandru@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, David Airlie <airlied@linux.ie>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Date: Mon, 11 Mar 2013 14:19:34 -0700
In-Reply-To: <1363034382-22752-1-git-send-email-gheorghiuandru@gmail.com>
References: <1363034382-22752-1-git-send-email-gheorghiuandru@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1264
Lines: 39

On Mon, 2013-03-11 at 22:39 +0200, Alexandru Gheorghiu wrote:
> Replaced calls to kmalloc followed by memcpy with a single call to kmemdup.
> Also removed a now redundant if statement.
[]
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
[]
> @@ -2335,11 +2335,8 @@ intel_dp_get_edid(struct drm_connector *connector, struct i2c_adapter *adapter)
>  			return NULL;
>  
>  		size = (intel_connector->edid->extensions + 1) * EDID_LENGTH;
> -		edid = kmalloc(size, GFP_KERNEL);
> -		if (!edid)
> -			return NULL;
> +		edid = kmemdup(intel_connector->edid, size, GFP_KERNEL);
>  
> -		memcpy(edid, intel_connector->edid, size);
>  		return edid;
>  	}
>  

Might as well get rid of the stack variable edid altogether.
Maybe get rid of size too and use:

	if (intel_connector->edid) {
		/* invalid edid */
		if (IS_ERR(intel_connector->edid))
			return NULL;

		return kmemdup(intel_connector->edid,
			       (intel_connector->edid->extensions + 1) * EDID_LENGTH,
			       GFP_KERNEL);
	}


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/