Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754446Ab3CKX5v (ORCPT ); Mon, 11 Mar 2013 19:57:51 -0400 Received: from mail-da0-f45.google.com ([209.85.210.45]:53462 "EHLO mail-da0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754045Ab3CKX5u convert rfc822-to-8bit (ORCPT ); Mon, 11 Mar 2013 19:57:50 -0400 MIME-Version: 1.0 In-Reply-To: <1363044388-11409-3-git-send-email-mirsal@mirsal.fr> References: <1363030315-10229-1-git-send-email-mirsal@mirsal.fr> <1363044388-11409-1-git-send-email-mirsal@mirsal.fr> <1363044388-11409-3-git-send-email-mirsal@mirsal.fr> Date: Mon, 11 Mar 2013 16:57:48 -0700 Message-ID: Subject: Re: [PATCH v2 2/3] drivers: android: binder: Fix code style From: =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= To: Mirsal Ennaime Cc: Greg Kroah-Hartman , Brian Swetland , devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Carpenter , Joe Perches Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1900 Lines: 45 On Mon, Mar 11, 2013 at 4:26 PM, Mirsal Ennaime wrote: > * Use tabs > * Remove a few "80-columns" checkpatch warnings > * Separate code paths with empty lines for readability > > Signed-off-by: Mirsal Ennaime > --- > drivers/staging/android/binder.c | 42 +++++++++++++++++++++++++------------- > 1 file changed, 28 insertions(+), 14 deletions(-) > > diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c > index 43f823d..4652cd8 100644 > --- a/drivers/staging/android/binder.c > +++ b/drivers/staging/android/binder.c > @@ -2927,57 +2927,69 @@ static void binder_deferred_release(struct binder_proc *proc) > { > struct binder_transaction *t; > struct rb_node *n; > - int threads, nodes, incoming_refs, outgoing_refs, buffers, active_transactions, page_count; > + int threads, nodes, incoming_refs, outgoing_refs, buffers, > + active_transactions, page_count; > > BUG_ON(proc->vma); > BUG_ON(proc->files); > > hlist_del(&proc->proc_node); > + > if (binder_context_mgr_node && binder_context_mgr_node->proc == proc) { > binder_debug(BINDER_DEBUG_DEAD_BINDER, > - "binder_release: %d context_mgr_node gone\n", > - proc->pid); > + "binder_release: %d context_mgr_node gone\n", > + proc->pid); I don't like this change (and the others like it). If is not uncommon the align arguments on that don't fit the first line with the arguments on the first line, so why change it here? -- Arve Hj?nnev?g -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/