Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754951Ab3CLBFE (ORCPT ); Mon, 11 Mar 2013 21:05:04 -0400 Received: from tundra.namei.org ([65.99.196.166]:60342 "EHLO tundra.namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754484Ab3CLBFD (ORCPT ); Mon, 11 Mar 2013 21:05:03 -0400 Date: Tue, 12 Mar 2013 12:05:53 +1100 (EST) From: James Morris To: Lucas De Marchi cc: Oleg Nesterov , lucas.de.marchi@gmail.com, David Howells , James Morris , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/7] KEYS: split call to call_usermodehelper_fns() In-Reply-To: <1363049291-946-4-git-send-email-lucas.demarchi@profusion.mobi> Message-ID: References: <1363049291-946-1-git-send-email-lucas.demarchi@profusion.mobi> <1363049291-946-4-git-send-email-lucas.demarchi@profusion.mobi> User-Agent: Alpine 2.02 (LRH 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 700 Lines: 22 On Mon, 11 Mar 2013, Lucas De Marchi wrote: > Use call_usermodehelper_setup() + call_usermodehelper_exec() instead of > calling call_usermodehelper_fns(). In case there's an OOM in this last > function the cleanup function may not be called - in this case we would > miss a call to key_put(). > > Signed-off-by: Lucas De Marchi Acked-by: James Morris -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/