Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754962Ab3CLB4b (ORCPT ); Mon, 11 Mar 2013 21:56:31 -0400 Received: from terminus.zytor.com ([198.137.202.10]:48585 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753549Ab3CLB4a (ORCPT ); Mon, 11 Mar 2013 21:56:30 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <20130311225048.GA3872@bremse> References: <1362718720-27048-1-git-send-email-yinghai@kernel.org> <1362718720-27048-2-git-send-email-yinghai@kernel.org> <20130308051059.GC14556@mtj.dyndns.org> <51398096.1060304@zytor.com> <20130311225048.GA3872@bremse> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH 01/14] x86, ACPI, mm: Kill max_low_pfn_mapped From: "H. Peter Anvin" Date: Mon, 11 Mar 2013 18:51:23 -0700 To: Daniel Vetter CC: Tejun Heo , Yinghai Lu , Thomas Gleixner , Ingo Molnar , Andrew Morton , Thomas Renninger , Tang Chen , linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Daniel Vetter , David Airlie , Jacob Shin , linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org Message-ID: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1330 Lines: 37 The problem is that the code will be broken, and so it makes no sense. The #if 0 is really confusing. Daniel Vetter wrote: >On Thu, Mar 07, 2013 at 10:09:26PM -0800, H. Peter Anvin wrote: >> On 03/07/2013 09:28 PM, Tejun Heo wrote: >> > On Thu, Mar 7, 2013 at 9:27 PM, Yinghai Lu >wrote: >> >> They are not using memblock_find_in_range(), so 1ULL<< will not >help. >> >> >> >> Really hope i915 drm guys could clean that hacks. >> > >> > The code isn't being used. Just leave it alone. Maybe add a >comment. >> > The change is just making things more confusing. >> > >> >> Indeed, but... >> >> Daniel: can you guys clean this up or can we just remove the #if 0 >clause? > >I guess we could just put this into a comment explaining where stolen >memory for the gfx devices is at on gen2. But tbh I don't mind if we >just >keep the #if 0 code around. For all newer platforms we can get at that >offset through mch bar registers, so I don't really care. >-Daniel -- Sent from my mobile phone. Please excuse brevity and lack of formatting. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/