Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932272Ab3CLGs1 (ORCPT ); Tue, 12 Mar 2013 02:48:27 -0400 Received: from mail-ob0-f176.google.com ([209.85.214.176]:63856 "EHLO mail-ob0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932065Ab3CLGsZ (ORCPT ); Tue, 12 Mar 2013 02:48:25 -0400 MIME-Version: 1.0 In-Reply-To: <1362945896-18475-1-git-send-email-silviupopescu1990@gmail.com> References: <1362945896-18475-1-git-send-email-silviupopescu1990@gmail.com> Date: Tue, 12 Mar 2013 08:48:24 +0200 Message-ID: Subject: Re: [PATCH] aic7xxx: fix coccicheck warnings From: Silviu Popescu To: linux-scsi@vger.kernel.org Cc: hare@suse.de, JBottomley@parallels.com, linux-kernel@vger.kernel.org, Silviu-Mihai Popescu Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2269 Lines: 58 On Sun, Mar 10, 2013 at 10:04 PM, Silviu-Mihai Popescu wrote: > This replaces a call to kmalloc() followed by memset() with just one > call to kzalloc(). > > Signed-off-by: Silviu-Mihai Popescu > --- > drivers/scsi/aic7xxx/aic79xx_osm.c | 3 +-- > drivers/scsi/aic7xxx/aic7xxx_osm.c | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/aic7xxx/aic79xx_osm.c b/drivers/scsi/aic7xxx/aic79xx_osm.c > index 9328121..f6fdb65 100644 > --- a/drivers/scsi/aic7xxx/aic79xx_osm.c > +++ b/drivers/scsi/aic7xxx/aic79xx_osm.c > @@ -1324,10 +1324,9 @@ int > ahd_platform_alloc(struct ahd_softc *ahd, void *platform_arg) > { > ahd->platform_data = > - kmalloc(sizeof(struct ahd_platform_data), GFP_ATOMIC); > + kzalloc(sizeof(struct ahd_platform_data), GFP_ATOMIC); > if (ahd->platform_data == NULL) > return (ENOMEM); > - memset(ahd->platform_data, 0, sizeof(struct ahd_platform_data)); > ahd->platform_data->irq = AHD_LINUX_NOIRQ; > ahd_lockinit(ahd); > ahd->seltime = (aic79xx_seltime & 0x3) << 4; > diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c > index 5a477cd..54bb1de 100644 > --- a/drivers/scsi/aic7xxx/aic7xxx_osm.c > +++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c > @@ -1222,10 +1222,9 @@ ahc_platform_alloc(struct ahc_softc *ahc, void *platform_arg) > { > > ahc->platform_data = > - kmalloc(sizeof(struct ahc_platform_data), GFP_ATOMIC); > + kzalloc(sizeof(struct ahc_platform_data), GFP_ATOMIC); > if (ahc->platform_data == NULL) > return (ENOMEM); > - memset(ahc->platform_data, 0, sizeof(struct ahc_platform_data)); > ahc->platform_data->irq = AHC_LINUX_NOIRQ; > ahc_lockinit(ahc); > ahc->seltime = (aic7xxx_seltime & 0x3) << 4; > -- > 1.7.9.5 > Hello, Would anyone be so kind as to review this? Thanks, Silviu Popescu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/