Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932357Ab3CLJHw (ORCPT ); Tue, 12 Mar 2013 05:07:52 -0400 Received: from mail.parknet.co.jp ([210.171.160.6]:46236 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754015Ab3CLJHu (ORCPT ); Tue, 12 Mar 2013 05:07:50 -0400 From: OGAWA Hirofumi To: Namjae Jeon Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, abartlet@samba.org, Namjae Jeon , Ravishankar N Subject: Re: [PATCH v3] fat: editions to support fat_fallocate References: <1362664617-3825-1-git-send-email-linkinjeon@gmail.com> <87sj44ac82.fsf@devron.myhome.or.jp> <87620y2d68.fsf@devron.myhome.or.jp> Date: Tue, 12 Mar 2013 18:07:44 +0900 In-Reply-To: (Namjae Jeon's message of "Tue, 12 Mar 2013 17:29:05 +0900") Message-ID: <87ip4xyoin.fsf@devron.myhome.or.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2590 Lines: 62 Namjae Jeon writes: >> If so, probably, I didn't clear my opinion/suggestion, or misled >> you. Sorry about it. >> >> My opinion/suggestion is, "it should be before umount()". >> I.e. fallocate() doesn't have any affect to FAT on clean state (clean >> umount). >> >> To clear my state, I don't have strong opinion about implementation yet. >> For example, about ->release() or ->evict_inode(). >> >> So, if you had reason to use ->release() over "we discussed", it would >> be good. (Or, if you still didn't have reasons, we would be better to >> think about it) > We considered all the possible points where we can release the > pre-allocated blocks. > As the "pre-allocation" is file based, we think it need to have > release mechanism. > > In case of evict, Eviction will either happen when the file is removed > or the inode is evicted from the cache by memory pressure when no > references are present for that file. > It is good that evict will be triggered in umount. but there is a risk > that umount time can be increased. > And It show users inconsistent result. e.g sometime user can not get > file discarded fallocated blocks by memory pressure. > > Let me know your opinion. Yes. My personal opinion is almost same, but I see some trade-off, and it is why I can't decide easily. Although I don't care about inconsistency on umount time. Because inconsistency window is opening while user is holding reference to inode, the window can already be enough big, and inconsistent only happens with crash. And if crashed, after all, both of ->release and ->evict requires fsck to recover FS. Possibly longer umount time (batch modify) and longer close time (on demand modify) are simply trade-off. Predictable behavior would matter. Yes, evict time doesn't guarantee to fallocate() is still available, however evict can be able to say it just guarantees to available fallocated blocks between open() and close(). Users have to call fallocate() again after close(), but fallocate() may skip actual allocation if blocks still available. I see optimization window with this evict behavior, because it can do batch discard of fallocated blocks on multiple files, and update FAT at once. However, ->release() would be simpler, and would more predictable. Thanks. -- OGAWA Hirofumi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/