Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932425Ab3CLJHz (ORCPT ); Tue, 12 Mar 2013 05:07:55 -0400 Received: from mga11.intel.com ([192.55.52.93]:32483 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932168Ab3CLJHw (ORCPT ); Tue, 12 Mar 2013 05:07:52 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,829,1355126400"; d="scan'208";a="300715833" Date: Tue, 12 Mar 2013 09:07:46 +0000 From: Chris Wilson To: Kees Cook Cc: linux-kernel@vger.kernel.org, Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Julien Tinnes , marcheu@chromium.org Subject: Re: [PATCH v3] drm/i915: bounds check execbuffer relocation count Message-ID: <20130312090746.GD31324@cantiga.alporthouse.com> Mail-Followup-To: Chris Wilson , Kees Cook , linux-kernel@vger.kernel.org, Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Julien Tinnes , marcheu@chromium.org References: <20130312003145.GA28993@www.outflux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130312003145.GA28993@www.outflux.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 942 Lines: 26 On Mon, Mar 11, 2013 at 05:31:45PM -0700, Kees Cook wrote: > It is possible to wrap the counter used to allocate the buffer for > relocation copies. This could lead to heap writing overflows. > > CVE-2013-0913 > > v3: collapse test, improve comment > v2: move check into validate_exec_list > > Signed-off-by: Kees Cook > Reported-by: Pinkie Pie > Cc: stable@vger.kernel.org Looks good to me. The only bikeshed that remains is whether we should just collapse the two variables into one, but the current 'max - count' is more idiomatic and so preferrable. Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/