Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932543Ab3CLKmb (ORCPT ); Tue, 12 Mar 2013 06:42:31 -0400 Received: from vpn.mirsal.fr ([178.79.141.108]:42902 "EHLO mirsal-laptop1.mirsal.fr" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753232Ab3CLKm3 (ORCPT ); Tue, 12 Mar 2013 06:42:29 -0400 From: Mirsal Ennaime To: Greg Kroah-Hartman Cc: =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= , Brian Swetland , devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Carpenter , Joe Perches , Mirsal Ennaime Subject: [PATCH v3 3/4] drivers: android: binder: Remove excessive indentation Date: Tue, 12 Mar 2013 11:42:01 +0100 Message-Id: <1363084922-19698-4-git-send-email-mirsal@mirsal.fr> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1363084922-19698-1-git-send-email-mirsal@mirsal.fr> References: <1363044388-11409-1-git-send-email-mirsal@mirsal.fr> <1363084922-19698-1-git-send-email-mirsal@mirsal.fr> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1653 Lines: 49 Remove one level of indentation from the binder proc page release code by using slightly different control semantics. Signed-off-by: Mirsal Ennaime --- drivers/staging/android/binder.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index ccf3087..9db21b4 100644 --- a/drivers/staging/android/binder.c +++ b/drivers/staging/android/binder.c @@ -3001,16 +3001,18 @@ static void binder_deferred_release(struct binder_proc *proc) int i; for (i = 0; i < proc->buffer_size / PAGE_SIZE; i++) { - if (proc->pages[i]) { - void *page_addr = proc->buffer + i * PAGE_SIZE; - binder_debug(BINDER_DEBUG_BUFFER_ALLOC, - "binder_release: %d: page %d at %p not freed\n", - proc->pid, i, page_addr); - unmap_kernel_range((unsigned long)page_addr, - PAGE_SIZE); - __free_page(proc->pages[i]); - page_count++; - } + void *page_addr; + + if (!proc->pages[i]) + continue; + + page_addr = proc->buffer + i * PAGE_SIZE; + binder_debug(BINDER_DEBUG_BUFFER_ALLOC, + "binder_release: %d: page %d at %p not freed\n", + proc->pid, i, page_addr); + unmap_kernel_range((unsigned long)page_addr, PAGE_SIZE); + __free_page(proc->pages[i]); + page_count++; } kfree(proc->pages); vfree(proc->buffer); -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/