Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932737Ab3CLLHg (ORCPT ); Tue, 12 Mar 2013 07:07:36 -0400 Received: from mail7.hitachi.co.jp ([133.145.228.42]:54439 "EHLO mail7.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754198Ab3CLLHf (ORCPT ); Tue, 12 Mar 2013 07:07:35 -0400 Message-ID: <513F0C74.4030101@hitachi.com> Date: Tue, 12 Mar 2013 20:07:32 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 5.2; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Ingo Molnar Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Timo Juhani Lindfors , Ananth N Mavinakayanahalli , Pavel Emelyanov , Jiri Kosina , Nadia Yvette Chambers , yrl.pp-manager.tt@hitachi.com, "David S. Miller" , Andrew Morton , Linus Torvalds Subject: Re: [PATCH -tip ] [BUGFIX] kprobes: Move hash_64() into .text.kprobe section References: <20130311142233.19885.10567.stgit@mhiramat-M0-7522> <20130312082112.GB30665@gmail.com> In-Reply-To: <20130312082112.GB30665@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1409 Lines: 42 (2013/03/12 17:21), Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > >> @@ -31,7 +32,7 @@ >> #error Wordsize not 32 or 64 >> #endif >> >> -static inline u64 hash_64(u64 val, unsigned int bits) >> +static __kprobes inline u64 hash_64(u64 val, unsigned int bits) >> { >> u64 hash = val; > > We should also, really, really fix the '__kprobes' misnomer and switch to > the '__noprobe' pattern or so. The naming does not make it obvious at all > that what we do here is to turn _off_ kprobing of select functions... Agreed. > The only complication is that __kprobes is now present in 600+ places, > which will create merge conflicts. If you remind me during the next merge > window I can generate the rename on the spot and send it to Linus without > anyone having to carry the patch for too long. Let me confirm that I just move __kprobes definition into compiler.h this time, and ping you when the next merge window opens, is that correct? Thank you, -- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/