Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932191Ab3CLO2d (ORCPT ); Tue, 12 Mar 2013 10:28:33 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:34684 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753694Ab3CLO2c (ORCPT ); Tue, 12 Mar 2013 10:28:32 -0400 Message-ID: <513F3B7E.8000002@ti.com> Date: Tue, 12 Mar 2013 16:28:14 +0200 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Marc Kleine-Budde CC: , , , , , , Subject: Re: [PATCH 1/8] usb: phy: nop: Add some parameters to platform data References: <1363087466-32444-1-git-send-email-rogerq@ti.com> <1363087466-32444-2-git-send-email-rogerq@ti.com> <513F177D.40500@pengutronix.de> <513F37DD.9030301@ti.com> <513F38DF.5040404@pengutronix.de> In-Reply-To: <513F38DF.5040404@pengutronix.de> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1543 Lines: 38 On 03/12/2013 04:17 PM, Marc Kleine-Budde wrote: > On 03/12/2013 03:12 PM, Roger Quadros wrote: >> On 03/12/2013 01:54 PM, Marc Kleine-Budde wrote: >>> On 03/12/2013 12:24 PM, Roger Quadros wrote: >>>> Add clk_rate parameter to platform data. If supplied, the >>>> NOP phy driver will program the clock to that rate during probe. >>>> >>>> Also add 2 flags, needs_vcc and needs_reset. >>>> If the flag is set and the regulator couldn't be found >>>> then the driver will bail out with -EPROBE_DEFER. >>> >>> Is there a platform which fills out pdata.needs_vcc and >>> pdata.needs_reset? IMHO it makes no sense to add features for the non DT >>> case, if there isn't any user for it. >>> >> >> There can be a user in the non DT case as well. Consider the following example: > > I'm just saying, let the implementation up to a real user for the non DT > case. Beagleboard is ARM and there's no point of implementing non DT > fall backs for ARM, IMHO. > Why do you say so? It doesn't depend on the CPU architecture. It depends on how the board designer wired the board. A non ARM platform could also face the same problem as beagle. It is not a non DT fallback. I believe many are still using non DT boot and it needs to work at least till we move all functionality to purely DT. cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/