Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755540Ab3CLPR3 (ORCPT ); Tue, 12 Mar 2013 11:17:29 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:37515 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755211Ab3CLPR1 convert rfc822-to-8bit (ORCPT ); Tue, 12 Mar 2013 11:17:27 -0400 From: "J, KEERTHY" To: "Menon, Nishanth" , "Cousson, Benoit" CC: "Shilimkar, Santosh" , cpufreq , "Rafael J. Wysocki" , Shawn Guo , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-omap@vger.kernel.org" Subject: RE: [PATCH 1/2] cpufreq: cpufreq-cpu0: support for clock which are not in DT yet. Thread-Topic: [PATCH 1/2] cpufreq: cpufreq-cpu0: support for clock which are not in DT yet. Thread-Index: AQHOHq0sSwuMoVRohkKj8PHRTVmzIJihJC4AgACcyACAAAMygIAAZYPw Date: Tue, 12 Mar 2013 15:17:20 +0000 Message-ID: References: <1363043130-30270-1-git-send-email-nm@ti.com> <1363043130-30270-2-git-send-email-nm@ti.com> <513EB704.8030907@ti.com> <513F3A88.5060903@ti.com> <20130312143535.GA21599@kahuna> In-Reply-To: <20130312143535.GA21599@kahuna> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.24.170.142] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5259 Lines: 145 Hi Nishanth, > -----Original Message----- > From: linux-omap-owner@vger.kernel.org [mailto:linux-omap- > owner@vger.kernel.org] On Behalf Of Menon, Nishanth > Sent: Tuesday, March 12, 2013 8:06 PM > To: Cousson, Benoit > Cc: Shilimkar, Santosh; cpufreq; Rafael J. Wysocki; Shawn Guo; linux- > kernel@vger.kernel.org; linux-pm@vger.kernel.org; linux- > omap@vger.kernel.org > Subject: Re: [PATCH 1/2] cpufreq: cpufreq-cpu0: support for clock which > are not in DT yet. > > On 15:24-20130312, Benoit Cousson wrote: > > Hi Guys, > > > > On 03/12/2013 06:03 AM, Santosh Shilimkar wrote: > > > On Tuesday 12 March 2013 04:35 AM, Nishanth Menon wrote: > > >> On certain SoCs like variants of OMAP, the clock conversion to DT > > >> is not complete. In short, the ability to: > > >> cpus { > > >> cpu@0 { > > >> clocks = <&cpuclk 0>; > > >> }; > > >> }; > > >> is not possible. However, the clock node is registered. > > >> Allow for clk names to be provided as string so as to be used when > needed. > > >> Example (for OMAP3630): > > >> cpus { > > >> cpu@0 { > > >> clock-name = "cpufreq_ck"; > > >> }; > > >> }; > > >> > > >> Cc: "Rafael J. Wysocki" > > >> Cc: Santosh Shilimkar > > >> Cc: Shawn Guo > > >> Cc: linux-kernel@vger.kernel.org > > >> Cc: cpufreq@vger.kernel.org > > >> Cc: linux-pm@vger.kernel.org > > >> Cc: linux-omap@vger.kernel.org > > >> > > >> Signed-off-by: Nishanth Menon > > >> --- > > > Seems a reasonable to me. > > > > No, it is not... > > > > You cannot add a temp binding just because the OMAP support is not > > there, since the real binding already exist. > > > > You need to register properly a clock provider to be able to > reference > > it. > > If you do need a hacky temp code you could do it in OMAP code but not > > in the binding. > > OK. My intent is to remove omap-cpufreq.c. So, I guess I could do > something like the following (not tested yet), but would that be the > right approach? Similar attempt was done for am33xx_clks in this by Shawn: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg84157.html > > diff --git a/arch/arm/mach-omap2/cclock2420_data.c b/arch/arm/mach- > omap2/cclock2420_data.c > index 0f0a97c..c3017deb 100644 > --- a/arch/arm/mach-omap2/cclock2420_data.c > +++ b/arch/arm/mach-omap2/cclock2420_data.c > @@ -1885,7 +1885,7 @@ static struct omap_clk omap2420_clks[] = { > CLK(NULL, "timer_32k_ck", &func_32k_ck, CK_242X), > CLK(NULL, "timer_sys_ck", &sys_ck, CK_242X), > CLK(NULL, "timer_ext_ck", &alt_ck, CK_242X), > - CLK(NULL, "cpufreq_ck", &virt_prcm_set, CK_242X), > + CLK(NULL, "cpufreq-cpu0.0", &virt_prcm_set, CK_242X), > }; > > > diff --git a/arch/arm/mach-omap2/cclock2430_data.c b/arch/arm/mach- > omap2/cclock2430_data.c > index aed8f74..7000ca4 100644 > --- a/arch/arm/mach-omap2/cclock2430_data.c > +++ b/arch/arm/mach-omap2/cclock2430_data.c > @@ -2001,7 +2001,7 @@ static struct omap_clk omap2430_clks[] = { > CLK(NULL, "timer_32k_ck", &func_32k_ck, CK_243X), > CLK(NULL, "timer_sys_ck", &sys_ck, CK_243X), > CLK(NULL, "timer_ext_ck", &alt_ck, CK_243X), > - CLK(NULL, "cpufreq_ck", &virt_prcm_set, CK_243X), > + CLK(NULL, "cpufreq-cpu0.0", &virt_prcm_set, CK_243X), Device name and the clk_name should be interchanged right? Something like this? CLK("cpufreq-cpu0.0", NULL, &virt_prcm_set, CK_243X), If yes the same should apply to all the instances. > }; > > static const char *enable_init_clks[] = { diff --git a/arch/arm/mach- > omap2/cclock3xxx_data.c b/arch/arm/mach-omap2/cclock3xxx_data.c > index 4579c3c..7a1dfde 100644 > --- a/arch/arm/mach-omap2/cclock3xxx_data.c > +++ b/arch/arm/mach-omap2/cclock3xxx_data.c > @@ -3501,7 +3501,7 @@ static struct omap_clk omap3xxx_clks[] = { > CLK(NULL, "uart4_ick", &uart4_ick_am35xx, CK_AM35XX), > CLK(NULL, "timer_32k_ck", &omap_32k_fck, CK_3XXX), > CLK(NULL, "timer_sys_ck", &sys_ck, CK_3XXX), > - CLK(NULL, "cpufreq_ck", &dpll1_ck, CK_3XXX), > + CLK(NULL, "cpufreq-cpu0.0", &dpll1_ck, CK_3XXX), > }; > > static const char *enable_init_clks[] = { diff --git a/arch/arm/mach- > omap2/cclock44xx_data.c b/arch/arm/mach-omap2/cclock44xx_data.c > index 3d58f33..5fad1da 100644 > --- a/arch/arm/mach-omap2/cclock44xx_data.c > +++ b/arch/arm/mach-omap2/cclock44xx_data.c > @@ -1660,7 +1660,7 @@ static struct omap_clk omap44xx_clks[] = { > CLK("4013a000.timer", "timer_sys_ck", &syc_clk_div_ck, > CK_443X), > CLK("4013c000.timer", "timer_sys_ck", &syc_clk_div_ck, > CK_443X), > CLK("4013e000.timer", "timer_sys_ck", &syc_clk_div_ck, > CK_443X), > - CLK(NULL, "cpufreq_ck", &dpll_mpu_ck, CK_443X), > + CLK(NULL, "cpufreq-cpu0.0", &dpll_mpu_ck, CK_443X), > }; > > int __init omap4xxx_clk_init(void) > -- > Regards, > Nishanth Menon > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" > in the body of a message to majordomo@vger.kernel.org More majordomo > info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/