Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932737Ab3CLP56 (ORCPT ); Tue, 12 Mar 2013 11:57:58 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:37807 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S932101Ab3CLP55 (ORCPT ); Tue, 12 Mar 2013 11:57:57 -0400 Date: Tue, 12 Mar 2013 11:57:56 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Roger Quadros , Felipe Balbi cc: gregkh@linuxfoundation.org, , , Kernel development list , USB list , , Subject: Re: [PATCH 11/12] USB: ehci-omap: Try to get PHY even if not in PHY mode In-Reply-To: <1363085090-24676-12-git-send-email-rogerq@ti.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1239 Lines: 36 On Tue, 12 Mar 2013, Roger Quadros wrote: > Even when not in PHY mode, the USB device on the port (e.g. HUB) > might need resources like RESET which can be modelled as a PHY > device. So try to get the PHY device in any case. > > Signed-off-by: Roger Quadros > CC: Alan Stern Acked-by: Alan Stern > /* get the PHY device */ > if (dev->of_node) > phy = devm_usb_get_phy_by_phandle(dev, "phys", i); > else > phy = devm_usb_get_phy_dev(dev, i); > if (IS_ERR(phy) || !phy) { > + /* Don't bail out if PHY is not absolutely necessary */ > + if (pdata->port_mode[i] != OMAP_EHCI_PORT_MODE_PHY) > + continue; > + > ret = IS_ERR(phy) ? PTR_ERR(phy) : -ENODEV; > dev_err(dev, "Can't get PHY device for port %d: %d\n", > i, ret); Felipe, this is a strange interface. Why do we sometimes get an error-pointer and sometimes get just NULL? Why not always an error-pointer? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/