Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933155Ab3CLQce (ORCPT ); Tue, 12 Mar 2013 12:32:34 -0400 Received: from multi.imgtec.com ([194.200.65.239]:37561 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932206Ab3CLQcd (ORCPT ); Tue, 12 Mar 2013 12:32:33 -0400 Message-ID: <513F5864.6090006@imgtec.com> Date: Tue, 12 Mar 2013 16:31:32 +0000 From: James Hogan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Jaehoon Chung CC: , , Seungwon Jeon , Chris Ball Subject: Re: [PATCH] mmc: dw_mmc: setpower on MMC_POWER_{UP,OFF} References: <1363085012-9220-1-git-send-email-james.hogan@imgtec.com> <513F10D9.9060402@samsung.com> In-Reply-To: <513F10D9.9060402@samsung.com> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.65] X-SEF-Processed: 7_3_0_01181__2013_03_12_16_32_30 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3393 Lines: 92 On 12/03/13 11:26, Jaehoon Chung wrote: > Looks good to me. > > Acked-by: Jaehoon Chung Thanks Jaehoon Cheers James > > Best Regards, > Jaehoon Chung > > On 03/12/2013 07:43 PM, James Hogan wrote: >> Call the setpower platform callback in response to set_ios with >> ios->power_mode == MMC_POWER_UP or MMC_POWER_OFF, instead of from the >> card detect work function. >> >> This appears to fix a problem I have where a card stuck in a funny state >> doesn't get properly cleared by the power being turned off, presumably >> due to lack of power sequencing. This resulted in the following log >> messages after boot: >> >> mmc0: error -110 whilst initialising SD card >> mmc_host mmc0: Bus speed (slot 0) = 99840000Hz (slot req 300000Hz, actual 298922HZ div = 167) >> mmc0: error -110 whilst initialising SD card >> mmc_host mmc0: Bus speed (slot 0) = 99840000Hz (slot req 200000Hz, actual 199680HZ div = 250) >> mmc0: error -110 whilst initialising SD card >> mmc_host mmc0: Bus speed (slot 0) = 99840000Hz (slot req 195765Hz, actual 195764HZ div = 255) >> mmc0: error -110 whilst initialising SD card >> mmc_host mmc0: Bus speed (slot 0) = 99840000Hz (slot req 400000Hz, actual 399360HZ div = 125) >> mmc0: error -110 whilst initialising SD card >> mmc_host mmc0: Bus speed (slot 0) = 99840000Hz (slot req 300000Hz, actual 298922HZ div = 167) >> >> Signed-off-by: James Hogan >> Cc: Seungwon Jeon >> Cc: Jaehoon Chung >> Cc: Chris Ball >> --- >> drivers/mmc/host/dw_mmc.c | 16 ++++++++-------- >> 1 file changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c >> index 60063cc..1a42c7c 100644 >> --- a/drivers/mmc/host/dw_mmc.c >> +++ b/drivers/mmc/host/dw_mmc.c >> @@ -818,6 +818,14 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) >> switch (ios->power_mode) { >> case MMC_POWER_UP: >> set_bit(DW_MMC_CARD_NEED_INIT, &slot->flags); >> + /* Power up slot */ >> + if (slot->host->pdata->setpower) >> + slot->host->pdata->setpower(slot->id, mmc->ocr_avail); >> + break; >> + case MMC_POWER_OFF: >> + /* Power down slot */ >> + if (slot->host->pdata->setpower) >> + slot->host->pdata->setpower(slot->id, 0); >> break; >> default: >> break; >> @@ -1674,10 +1682,6 @@ static void dw_mci_work_routine_card(struct work_struct *work) >> dev_dbg(&slot->mmc->class_dev, "card %s\n", >> present ? "inserted" : "removed"); >> >> - /* Power up slot (before spin_lock, may sleep) */ >> - if (present != 0 && host->pdata->setpower) >> - host->pdata->setpower(slot->id, mmc->ocr_avail); >> - >> spin_lock_bh(&host->lock); >> >> /* Card change detected */ >> @@ -1760,10 +1764,6 @@ static void dw_mci_work_routine_card(struct work_struct *work) >> >> spin_unlock_bh(&host->lock); >> >> - /* Power down slot (after spin_unlock, may sleep) */ >> - if (present == 0 && host->pdata->setpower) >> - host->pdata->setpower(slot->id, 0); >> - >> present = dw_mci_get_cd(mmc); >> } >> >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/