Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933342Ab3CLSmL (ORCPT ); Tue, 12 Mar 2013 14:42:11 -0400 Received: from wolverine02.qualcomm.com ([199.106.114.251]:52590 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933234Ab3CLSmG (ORCPT ); Tue, 12 Mar 2013 14:42:06 -0400 X-IronPort-AV: E=Sophos;i="4.84,832,1355126400"; d="scan'208";a="29083604" From: David Brown To: Greg Kroah-Hartman Cc: David Brown , Daniel Walker , Bryan Huntsman , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 03/11] ssbi: Fix exit mismatch in remove function Date: Tue, 12 Mar 2013 11:41:48 -0700 Message-Id: <1363113716-25897-4-git-send-email-davidb@codeaurora.org> X-Mailer: git-send-email 1.8.1.4 In-Reply-To: <1363113716-25897-1-git-send-email-davidb@codeaurora.org> References: <1362616187-21089-1-git-send-email-davidb@codeaurora.org> <1363113716-25897-1-git-send-email-davidb@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1251 Lines: 36 msm_ssbi_remove is referenced with __exit_p, but not declared with __exit. This causes a warning when the driver is not built as a module: drivers/ssbi/ssbi.c:341:23: warning: 'msm_ssbi_remove' defined but not used [-Wunused-function] The remove is needed for unbinding to work, even if not compiled as a module, so just remove it. Signed-off-by: David Brown --- drivers/ssbi/ssbi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ssbi/ssbi.c b/drivers/ssbi/ssbi.c index c08a7b8..da086d4 100644 --- a/drivers/ssbi/ssbi.c +++ b/drivers/ssbi/ssbi.c @@ -372,7 +372,7 @@ static int msm_ssbi_remove(struct platform_device *pdev) static struct platform_driver msm_ssbi_driver = { .probe = msm_ssbi_probe, - .remove = __exit_p(msm_ssbi_remove), + .remove = msm_ssbi_remove, .driver = { .name = "msm_ssbi", .owner = THIS_MODULE, -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/