Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755616Ab3CLTUW (ORCPT ); Tue, 12 Mar 2013 15:20:22 -0400 Received: from mail-ve0-f173.google.com ([209.85.128.173]:39309 "EHLO mail-ve0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755274Ab3CLTUU (ORCPT ); Tue, 12 Mar 2013 15:20:20 -0400 MIME-Version: 1.0 In-Reply-To: <20130312191118.GA17439@redhat.com> References: <1363058712.4534.12.camel@pasglop> <20130312182210.GA15862@redhat.com> <20130312191118.GA17439@redhat.com> Date: Tue, 12 Mar 2013 12:20:19 -0700 X-Google-Sender-Auth: W0VfZJCOHc7yvQUkVwGpZ9pMbfs Message-ID: Subject: Re: Regression with orderly_poweroff() From: Linus Torvalds To: Oleg Nesterov Cc: Andi Kleen , Lucas De Marchi , Benjamin Herrenschmidt , Linux Kernel Mailing List , Paul Mackerras , david@gibson.dropbear.id.au, Kees Cook , Serge Hallyn , "Rafael J. Wysocki" , Andrew Morton , Feng Hong , Lucas De Marchi Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 790 Lines: 17 On Tue, Mar 12, 2013 at 12:11 PM, Oleg Nesterov wrote: > > Confused... which arguments? The only argument is poweroff_cmd, it can't > go away and kmalloc(GFP_KERNEL) is fine in work->func() ? Hmm. I guess in this particular situation, we really don't have any arguments from callers, no. I was confused by the fact that we had that argv_split/argv_free thing, but that doesn't actually come from the callers, it just comes from our own buffer. So yeah, I guess everything could just go into a workqueue. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/