Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933404Ab3CLX0q (ORCPT ); Tue, 12 Mar 2013 19:26:46 -0400 Received: from mail-la0-f43.google.com ([209.85.215.43]:55091 "EHLO mail-la0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753819Ab3CLX0o (ORCPT ); Tue, 12 Mar 2013 19:26:44 -0400 MIME-Version: 1.0 In-Reply-To: <20130312134528.GA28019@roeck-us.net> References: <1363077566-6254-1-git-send-email-ch.naveen@samsung.com> <20130312134528.GA28019@roeck-us.net> Date: Tue, 12 Mar 2013 16:26:42 -0700 X-Google-Sender-Auth: GWBS7tS3K_6uadrPefhn4h5h-oI Message-ID: Subject: Re: [PATCH v2] hwmon: ntc: Add DT with IIO support to NTC thermistor driver From: Doug Anderson To: Guenter Roeck Cc: Naveen Krishna Chatradhi , "linux-kernel@vger.kernel.org" , lm-sensors@lm-sensors.org, devicetree-discuss@lists.ozlabs.org, Jean Delvare , Naveen Krishna Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2059 Lines: 57 Hi, On Tue, Mar 12, 2013 at 6:45 AM, Guenter Roeck wrote: > On Tue, Mar 12, 2013 at 02:09:26PM +0530, Naveen Krishna Chatradhi wrote: >> This patch adds DT support to NTC driver to parse the >> platform data. >> >> Also adds the support to work as an iio device. >> >> During the probe ntc driver gets the respective channels of ADC >> and uses iio_raw_read calls to get the ADC converted value. >> >> Signed-off-by: Naveen Krishna Chatradhi I know that there is still work to do to address Guenter's comments, but I spent a little time playing with this today to see what else was missing and actually got it working. :) I'll add a "Tested-by" once Naveen reposts. I sent up my patches that I needed to the ADC + device trees to get it working, but I just realized that I forgot to CC Guenter. Doh! In case you're curious, you can find them at: * https://patchwork.kernel.org/patch/2260231/ * https://patchwork.kernel.org/patch/2260211/ * https://patchwork.kernel.org/patch/2260221/ * https://patchwork.kernel.org/patch/2260201/ > You'll still need the conditional dependency on IIO in Kconfig. > Something like > depends on IIO if OF > if that works, or alternatively > select IIO if OF > if that is acceptable. This was important for me. I had IIO setup as a module and adc configured an in-kernel. Without the above I got a nice linker error. ;) The syntax that worked for me was 'select IIO if OF'. I don't think you can do a conditional depends on (it didn't work for me and I couldn't find any examples like that). >> +Read more about iio bindings at >> + Documentation/devicetree/bindings/iio/iio-bindings.txt >> + BTW: the above line had a whitespace error on it. Double-check that it's gone for the next version. -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/