Date: Wed, 13 Mar 2013 09:37:20 +0100
From: Samuel Ortiz <sameo@linux.intel.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: gg@slimlogic.co.uk, broonie@opensource.wolfsonmicro.com,
        linux-kernel@vger.kernel.org, swarren@nvidia.com, ian@slimlogic.co.uk
Subject: Re: [PATCH V2] mfd: palmas: provide irq flags through DT/platform
 data
Message-ID: <20130313083720.GD21994@zurbaran>
References: <1362149026-21170-1-git-send-email-ldewangan@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1362149026-21170-1-git-send-email-ldewangan@nvidia.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1332
Lines: 36

Hi Laxman,

On Fri, Mar 01, 2013 at 08:13:46PM +0530, Laxman Dewangan wrote:
> Currently driver sets the irq type to IRQF_TRIGGER_LOW which is
> causing interrupt registration failure in ARM based SoCs as:
> [    0.208479] genirq: Setting trigger mode 8 for irq 118 failed (gic_set_type+0x0/0xf0)
> [    0.208513] dummy 0-0059: Failed to request IRQ 118: -22
> 
> Provide the irq flags through platform data if device is registered
> through board file or get the irq type from DT node property in place
> of hardcoding the irq flag in driver to support multiple platforms.
> 
> Also configure the device to generate the interrupt signal according to
> flag type.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> ---
> Changes from V1:
> - Use palmas_update_bits() for rea/modiy/write.
> 
>  drivers/mfd/palmas.c       |   36 +++++++++++++++++++++++++++++++++---
>  include/linux/mfd/palmas.h |    1 +
>  2 files changed, 34 insertions(+), 3 deletions(-)
Patch applied to my mfd-fixes tree now.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/