Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756080Ab3CMLNG (ORCPT ); Wed, 13 Mar 2013 07:13:06 -0400 Received: from mercuryimc.plus.com ([80.229.200.144]:44409 "EHLO centos1.newflow.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754451Ab3CMLND (ORCPT ); Wed, 13 Mar 2013 07:13:03 -0400 Message-ID: <51405F3A.3090901@mimc.co.uk> Date: Wed, 13 Mar 2013 11:12:58 +0000 From: Mark Jackson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130221 Thunderbird/17.0.3 MIME-Version: 1.0 To: dedekind1@gmail.com CC: "linux-mtd@lists.infradead.org" , "linux-omap@vger.kernel.org" , lkml , adrian.hunter@intel.com Subject: Re: MTD : Kernel oops when remounting ubifs as read/write References: <5134CEF9.5070502@mimc.co.uk> <1363087506.3348.62.camel@sauron.fi.intel.com> In-Reply-To: <1363087506.3348.62.camel@sauron.fi.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3138 Lines: 69 On 12/03/13 11:25, Artem Bityutskiy wrote: > On Mon, 2013-03-04 at 16:42 +0000, Mark Jackson wrote: >> I'm encountering an oops when remounting my ubifs volume as read/write. >> >> # mount -o remount,rw / >> [ 89.434974] UBIFS assert failed in ubifs_write_node at 869 (pid 628) >> [ 89.442122] [] (unwind_backtrace+0x0/0xf0) from [] (ubifs_write_node+0x180/0x1c4) >> [ 89.451896] [] (ubifs_write_node+0x180/0x1c4) from [] (ubifs_write_master+0x9c/0x134) >> [ 89.462018] [] (ubifs_write_master+0x9c/0x134) from [] (ubifs_remount_fs+0x5d4/0x7f8) >> [ 89.472133] [] (ubifs_remount_fs+0x5d4/0x7f8) from [] (do_remount_sb+0x98/0x16c) >> [ 89.481790] [] (do_remount_sb+0x98/0x16c) from [] (do_mount+0x830/0x888) >> [ 89.490708] [] (do_mount+0x830/0x888) from [] (sys_mount+0x84/0xb8) >> [ 89.499178] [] (sys_mount+0x84/0xb8) from [] (ret_fast_syscall+0x0/0x3c) >> [ 89.510997] UBIFS assert failed in ubifs_write_node at 869 (pid 628) >> [ 89.517884] [] (unwind_backtrace+0x0/0xf0) from [] (ubifs_write_node+0x180/0x1c4) >> [ 89.527641] [] (ubifs_write_node+0x180/0x1c4) from [] (ubifs_write_master+0xd8/0x134) >> [ 89.537760] [] (ubifs_write_master+0xd8/0x134) from [] (ubifs_remount_fs+0x5d4/0x7f8) >> [ 89.547869] [] (ubifs_remount_fs+0x5d4/0x7f8) from [] (do_remount_sb+0x98/0x16c) >> [ 89.557526] [] (do_remount_sb+0x98/0x16c) from [] (do_mount+0x830/0x888) >> [ 89.566435] [] (do_mount+0x830/0x888) from [] (sys_mount+0x84/0xb8) >> [ 89.574905] [] (sys_mount+0x84/0xb8) from [] (ret_fast_syscall+0x0/0x3c) >> [ 89.585939] UBIFS: start fixing up free space >> [ 89.592237] UBIFS: background thread "ubifs_bgt0_0" started, PID 629 >> [ 91.419951] UBIFS: free space fixup complete >> # >> >> If it's any help, if the remount is put into my inittab, I don't get any oops. > > Would you please try this patch (also attached): > > diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c > index ac838b8..9791b3c 100644 > --- a/fs/ubifs/super.c > +++ b/fs/ubifs/super.c > @@ -1568,6 +1568,12 @@ static int ubifs_remount_rw(struct ubifs_info *c) > c->remounting_rw = 1; > c->ro_mount = 0; > > + if (c->space_fixup) { > + err = ubifs_fixup_free_space(c); > + if (err) > + goto out; > + } > + > err = check_free_space(c); > if (err) > goto out; > @@ -1684,12 +1690,6 @@ static int ubifs_remount_rw(struct ubifs_info *c) > err = dbg_check_space_info(c); > } > > - if (c->space_fixup) { > - err = ubifs_fixup_free_space(c); > - if (err) > - goto out; > - } > - > mutex_unlock(&c->umount_mutex); > return err; > Sorry ... this just locks up the unit. Mark J. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/