Date: Wed, 13 Mar 2013 13:30:45 +0200
From: Lasse Collin <lasse.collin@tukaani.org>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Florian Fainelli <florian@openwrt.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] decompressors: fix typo "POWERPC"
Message-ID: <20130313133045.51d44a63@tukaani.org>
In-Reply-To: <1363044544.3137.120.camel@x61.thuisdomein>
References: <1363044544.3137.120.camel@x61.thuisdomein>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1238
Lines: 29

On 2013-03-12 Paul Bolle wrote:
> Commit 5dc49c75a26b99e86a18441e0b64c1f7c7c6a500 ("decompressors: make
> the default XZ_DEC_* config match the selected architecture") added
> 	default y if POWERPC
> 
> to lib/xz/Kconfig. But there is no Kconfig symbol POWERPC. The most
> general Kconfig symbol for the powerpc architecture is PPC. So let's
> use that.

Thanks.

> 1) By the way: why does the XZ related code use both the macro
> CONFIG_XZ_DEC_POWERPC and the macro XZ_DEC_POWERPC? (Ditto for other
> architectures.) That looks odd.

In a preboot environment the options selected for the xz_dec module are
ignored. If XZ-compressed kernel is selected, lib/decompress_unxz.c
will enable a BCJ filter for that architecture. An alternative could be
to #undef the CONFIG_XZ_DEC_foo symbols in decompress_unxz.c and then
#define what is needed for the selected architecture, but I think the
current method is OK. See also lib/xz/xz_private.h.

-- 
Lasse Collin  |  IRC: Larhzu @ IRCnet & Freenode
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/