Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756326Ab3CMM3d (ORCPT ); Wed, 13 Mar 2013 08:29:33 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:55634 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755366Ab3CMM3c (ORCPT ); Wed, 13 Mar 2013 08:29:32 -0400 Message-ID: <51407120.7030709@ti.com> Date: Wed, 13 Mar 2013 17:59:20 +0530 From: Lokesh Vutla User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120912 Thunderbird/15.0.1 MIME-Version: 1.0 To: Dietmar Eggemann CC: Will Deacon , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" , "santosh.shilimkar@ti.com" Subject: Re: [PATCH] ARM: hw_breakpoint: Enable debug powerdown only if system supports 'has_ossr' References: <1363157553-21085-1-git-send-email-lokeshvutla@ti.com> <51406BA7.8010306@arm.com> In-Reply-To: <51406BA7.8010306@arm.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2912 Lines: 79 Hi Dietmar, On Wednesday 13 March 2013 05:35 PM, Dietmar Eggemann wrote: > On 13/03/13 06:52, Lokesh Vutla wrote: >> Commit {9a6eb31 ARM: hw_breakpoint: Debug powerdown support for >> self-hosted >> debug} introduces debug powerdown support for self-hosted debug. >> While merging the patch 'has_ossr' check was removed which >> was needed for hardwares which doesn't support self-hosted debug. >> Pandaboard (A9) is one such hardware and Dietmar's orginial >> patch did mention this issue. >> Without that check on Panda with CPUIDLE enabled, a flood of >> below messages thrown. >> >> [ 3.597930] hw-breakpoint: CPU 0 failed to disable vector catch >> [ 3.597991] hw-breakpoint: CPU 1 failed to disable vector catch >> > > Hi Lokesh, > > I confirm that this has_ossr condition has to go back into the > pm_init(void) call. I just verified it again on my Panda board and I get > the same issue like you without it. > > I guess what was happening is that Will asked me if this check is really > necessary and I said No without re-testing on my Panda board as an V7 > debug architecture example where OSSR is not implemented. Since then I > only tested in on V7.1 debug architectures where OSSR is mandatory. > Sorry about this and thanks for catching this. Thanks for confirming..:) Regards, Lokesh > > You can add my Acked-by: if you wish. > > -- Dietmar > >> So restore that check back to avoid the mentioned issue. >> >> Cc: Dietmar Eggemann >> Cc: Will Deacon >> Reported-by: Santosh Shilimkar >> Acked-by: Santosh Shilimkar >> Signed-off-by: Lokesh Vutla >> --- >> arch/arm/kernel/hw_breakpoint.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/kernel/hw_breakpoint.c >> b/arch/arm/kernel/hw_breakpoint.c >> index 96093b7..0ba062d 100644 >> --- a/arch/arm/kernel/hw_breakpoint.c >> +++ b/arch/arm/kernel/hw_breakpoint.c >> @@ -1049,7 +1049,8 @@ static struct notifier_block __cpuinitdata >> dbg_cpu_pm_nb = { >> >> static void __init pm_init(void) >> { >> - cpu_pm_register_notifier(&dbg_cpu_pm_nb); >> + if (has_ossr) >> + cpu_pm_register_notifier(&dbg_cpu_pm_nb); >> } >> #else >> static inline void pm_init(void) >> > > -- IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy > the information in any medium. Thank you. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/