Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756398Ab3CMNeV (ORCPT ); Wed, 13 Mar 2013 09:34:21 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:46967 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751901Ab3CMNeT (ORCPT ); Wed, 13 Mar 2013 09:34:19 -0400 Date: Wed, 13 Mar 2013 09:33:56 -0400 From: Neil Horman To: Xufeng Zhang Cc: vyasevich@gmail.com, davem@davemloft.net, linux-sctp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sctp: don't break the loop while meeting the active_path so as to find the matched transport Message-ID: <20130313133356.GD17592@hmsreliant.think-freely.org> References: <1362728377-11025-1-git-send-email-xufeng.zhang@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1362728377-11025-1-git-send-email-xufeng.zhang@windriver.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Score: -2.9 (--) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1500 Lines: 39 On Fri, Mar 08, 2013 at 03:39:37PM +0800, Xufeng Zhang wrote: > sctp_assoc_lookup_tsn() function searchs which transport a certain TSN > was sent on, if not found in the active_path transport, then go search > all the other transports in the peer's transport_addr_list, however, we > should continue to the next entry rather than break the loop when meet > the active_path transport. > > Signed-off-by: Xufeng Zhang > --- > net/sctp/associola.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/sctp/associola.c b/net/sctp/associola.c > index 43cd0dd..d2709e2 100644 > --- a/net/sctp/associola.c > +++ b/net/sctp/associola.c > @@ -1079,7 +1079,7 @@ struct sctp_transport *sctp_assoc_lookup_tsn(struct sctp_association *asoc, > transports) { > > if (transport == active) > - break; > + continue; > list_for_each_entry(chunk, &transport->transmitted, > transmitted_list) { > if (key == chunk->subh.data_hdr->tsn) { > -- > 1.7.0.2 > Based on discussion with Vlad, it seems theres arguably some work to do on access to the transport_addr_list before my solution is viable, so until I get to that I'm acking this patch. Acked-by: Neil Horman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/