Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756441Ab3CMNrD (ORCPT ); Wed, 13 Mar 2013 09:47:03 -0400 Received: from mail9.hitachi.co.jp ([133.145.228.44]:36694 "EHLO mail9.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756330Ab3CMNrA (ORCPT ); Wed, 13 Mar 2013 09:47:00 -0400 Message-ID: <51408349.8080800@hitachi.com> Date: Wed, 13 Mar 2013 22:46:49 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 5.2; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Timo Juhani Lindfors Cc: Linus Torvalds , Ingo Molnar , Linux Kernel Mailing List , Ananth N Mavinakayanahalli , Pavel Emelyanov , Jiri Kosina , Nadia Yvette Chambers , yrl.pp-manager.tt@hitachi.com, "David S. Miller" Subject: Re: [PATCH -tip ] [BUGFIX] kprobes: Move hash_64() into .text.kprobe section References: <20130311142233.19885.10567.stgit@mhiramat-M0-7522> <514023AA.4070004@hitachi.com> <847glb8m4i.fsf@sauna.l.org> In-Reply-To: <847glb8m4i.fsf@sauna.l.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1002 Lines: 29 (2013/03/13 22:28), Timo Juhani Lindfors wrote: > Masami Hiramatsu writes: >> OK, then I'll update it to just use __always_inline. > > I get a similar case of infinite recursion if I try to kprobe > "inat_get_opcode_attribute": Oops, right! And this is caused by below callchain set_current_kprobes->is_IF_modifier->skip_prefixes ->inat_get_opcode_attribute However, this looks very wired that the copied instruction (ainsn->insn) is analyzed at every probe hit. I think we should add a bit flag indicating IF modifier to the ainsn. Thank you for reporting!! -- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/