Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933007Ab3CMNwz (ORCPT ); Wed, 13 Mar 2013 09:52:55 -0400 Received: from mail-ve0-f178.google.com ([209.85.128.178]:65164 "EHLO mail-ve0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751901Ab3CMNwy (ORCPT ); Wed, 13 Mar 2013 09:52:54 -0400 Message-ID: <514084B0.4050906@gmail.com> Date: Wed, 13 Mar 2013 09:52:48 -0400 From: Vlad Yasevich User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Xufeng Zhang CC: nhorman@tuxdriver.com, davem@davemloft.net, linux-sctp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sctp: don't break the loop while meeting the active_path so as to find the matched transport References: <1362728377-11025-1-git-send-email-xufeng.zhang@windriver.com> In-Reply-To: <1362728377-11025-1-git-send-email-xufeng.zhang@windriver.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1289 Lines: 35 On 03/08/2013 02:39 AM, Xufeng Zhang wrote: > sctp_assoc_lookup_tsn() function searchs which transport a certain TSN > was sent on, if not found in the active_path transport, then go search > all the other transports in the peer's transport_addr_list, however, we > should continue to the next entry rather than break the loop when meet > the active_path transport. > > Signed-off-by: Xufeng Zhang > --- > net/sctp/associola.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/sctp/associola.c b/net/sctp/associola.c > index 43cd0dd..d2709e2 100644 > --- a/net/sctp/associola.c > +++ b/net/sctp/associola.c > @@ -1079,7 +1079,7 @@ struct sctp_transport *sctp_assoc_lookup_tsn(struct sctp_association *asoc, > transports) { > > if (transport == active) > - break; > + continue; > list_for_each_entry(chunk, &transport->transmitted, > transmitted_list) { > if (key == chunk->subh.data_hdr->tsn) { > Acked-by: Vlad Yasevich -vlad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/