Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933787Ab3CMPR7 (ORCPT ); Wed, 13 Mar 2013 11:17:59 -0400 Received: from gate.crashing.org ([63.228.1.57]:40306 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932391Ab3CMPR5 (ORCPT ); Wed, 13 Mar 2013 11:17:57 -0400 Subject: Re: [libvirt] if_bridge.h: include in6.h for struct in6_addr use Mime-Version: 1.0 (Apple Message framework v1278) Content-Type: text/plain; charset=us-ascii From: Kumar Gala In-Reply-To: <50F49B7E.50906@redhat.com> Date: Wed, 13 Mar 2013 10:17:40 -0500 Cc: Thomas Backlund , netdev@vger.kernel.org, "linux-kernel@vger.kernel.org list" , libvirt-list@redhat.com, stephen@networkplumber.org, Zhenhua Luo Content-Transfer-Encoding: 7bit Message-Id: <81B30F90-5A18-4386-9C30-E336AE212D85@kernel.crashing.org> References: <50F2FF1B.3020708@mageia.org> <50F313A5.3020707@mageia.org> <50F49B7E.50906@redhat.com> To: Eric Blake X-Mailer: Apple Mail (2.1278) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1564 Lines: 50 On Jan 14, 2013, at 5:57 PM, Eric Blake wrote: > On 01/13/2013 01:05 PM, Thomas Backlund wrote: >> Thomas Backlund skrev 13.1.2013 20:38: >>> patch both inline and attached as thunderbird tends to mess up ... >> >>> ----- >>> >>> if_bridge.h uses struct in6_addr ip6; but does not include the in6.h >>> header. >>> >>> Found by trying to build libvirt and connman against 3.8-rc3 headers. >>> >> >> Ok, >> ignore this patch, it's not the correct fix as it introduces >> redefinitions... >> >> Btw, the error that I hit that made me suggest this fix was libvirt >> config check bailing out: >> >> config.log:/usr/include/linux/if_bridge.h:173:20: error: field 'ip6' has >> incomplete type > > Hmm, just now noticing this thread, after independently hitting and and > having to work around the same problem in libvirt: > https://www.redhat.com/archives/libvir-list/2013-January/msg00930.html > https://bugzilla.redhat.com/show_bug.cgi?id=895141 > >>> --- linux-3.8-rc3/include/uapi/linux/if_bridge.h 2013-01-13 >>> 20:09:54.257271755 +0200 >>> +++ linux-3.8-rc3.fix/include/uapi/linux/if_bridge.h 2013-01-13 >>> 20:15:04.153676151 +0200 >>> @@ -14,6 +14,7 @@ >>> #define _UAPI_LINUX_IF_BRIDGE_H >>> >>> #include >>> +#include >>> Did this ever get resolved ? - k -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/