Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933997Ab3CMPxL (ORCPT ); Wed, 13 Mar 2013 11:53:11 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:33397 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933817Ab3CMPxJ (ORCPT ); Wed, 13 Mar 2013 11:53:09 -0400 MIME-Version: 1.0 Reply-To: sedat.dilek@gmail.com In-Reply-To: References: <1363184193-1796-1-git-send-email-miklos@szeredi.hu> Date: Wed, 13 Mar 2013 16:53:08 +0100 Message-ID: Subject: Re: [PATCH 0/9] overlay filesystem: request for inclusion (v17) From: Sedat Dilek To: Miklos Szeredi Cc: viro@zeniv.linux.org.uk, torvalds@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, hch@infradead.org, akpm@linux-foundation.org, apw@canonical.com, nbd@openwrt.org, neilb@suse.de, jordipujolp@gmail.com, ezk@fsl.cs.sunysb.edu, dhowells@redhat.com, sedat.dilek@googlemail.com, hooanon05@yahoo.co.jp, mszeredi@suse.cz Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2301 Lines: 72 On Wed, Mar 13, 2013 at 4:26 PM, Sedat Dilek wrote: > On Wed, Mar 13, 2013 at 4:18 PM, Miklos Szeredi wrote: >>> Looks like this is missing (or intended?): >>> >>> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c >>> index 482c26f..f23ebfc 100644 >>> --- a/fs/overlayfs/super.c >>> +++ b/fs/overlayfs/super.c >>> @@ -684,3 +684,6 @@ static void __exit ovl_exit(void) >>> >>> module_init(ovl_init); >>> module_exit(ovl_exit); >>> +MODULE_DESCRIPTION("overlayfs v17: provides overlay-filesystem functionality"); >>> +MODULE_AUTHOR("Miklos Szeredi "); >>> +MODULE_LICENSE("GPL"); >> >> No, it *is* already in there. >> > > Where is it? > > Last lines in [1] are: > > 685 module_init(ovl_init); > 686 module_exit(ovl_exit); > OK, I looked at SquashFS which is not converted to use MODULE_ALIAS_FS. Hehe, with my patch that looks now funny :-). $ sudo modinfo overlayfs filename: /lib/modules/3.9.0-rc2-next20130313-4-iniza-small/kernel/fs/overlayfs/overlayfs.ko license: GPL author: Miklos Szeredi description: overlayfs v17, provides overlay-filesystem functionality alias: fs-overlayfs license: GPL description: Overlay filesystem author: Miklos Szeredi srcversion: 4332BB91603829A85CCEA59 depends: intree: Y vermagic: 3.9.0-rc2-next20130313-4-iniza-small SMP mod_unload modversions $ sudo modinfo squashfs filename: /lib/modules/3.9.0-rc2-next20130313-4-iniza-small/kernel/fs/squashfs/squashfs.ko license: GPL author: Phillip Lougher description: squashfs 4.0, a compressed read-only filesystem alias: fs-squashfs srcversion: 752DB671D8E8DFB606BFC88 depends: intree: Y vermagic: 3.9.0-rc2-next20130313-4-iniza-small SMP mod_unload modversions - Sedat - > - Sedat - > > [1] http://git.kernel.org/cgit/linux/kernel/git/mszeredi/vfs.git/tree/fs/overlayfs/super.c?h=overlayfs.current > >> Thanks, >> Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/