Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933057Ab3CMQpq (ORCPT ); Wed, 13 Mar 2013 12:45:46 -0400 Received: from mail-da0-f47.google.com ([209.85.210.47]:44478 "EHLO mail-da0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755591Ab3CMQpo (ORCPT ); Wed, 13 Mar 2013 12:45:44 -0400 Message-ID: <5140AD31.30907@gmail.com> Date: Thu, 14 Mar 2013 00:45:37 +0800 From: Jiang Liu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130221 Thunderbird/17.0.3 MIME-Version: 1.0 To: Yasuaki Ishimatsu CC: Andrew Morton , David Rientjes , Jiang Liu , Wen Congyang , Maciej Rutecki , Chris Clayton , "Rafael J . Wysocki" , Mel Gorman , Minchan Kim , KAMEZAWA Hiroyuki , Michal Hocko , Jianguo Wu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" Subject: Re: [PATCH v2, part1 25/29] mm/x86: use common help functions to free reserved pages References: <1362896833-21104-1-git-send-email-jiang.liu@huawei.com> <1362896833-21104-26-git-send-email-jiang.liu@huawei.com> <514010B8.2030304@jp.fujitsu.com> In-Reply-To: <514010B8.2030304@jp.fujitsu.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2228 Lines: 74 On 03/13/2013 01:38 PM, Yasuaki Ishimatsu wrote: > Hi Jiang, > > 2013/03/10 15:27, Jiang Liu wrote: >> Use common help functions to free reserved pages. >> >> Signed-off-by: Jiang Liu >> Cc: Thomas Gleixner >> Cc: Ingo Molnar >> Cc: "H. Peter Anvin" >> --- >> arch/x86/mm/init.c | 5 +---- >> arch/x86/mm/init_64.c | 5 ++--- >> 2 files changed, 3 insertions(+), 7 deletions(-) >> >> diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c >> index 4903a03..4a705e6 100644 >> --- a/arch/x86/mm/init.c >> +++ b/arch/x86/mm/init.c >> @@ -516,11 +516,8 @@ void free_init_pages(char *what, unsigned long begin, unsigned long end) > >> printk(KERN_INFO "Freeing %s: %luk freed\n", what, (end - begin) >> 10); >> >> for (; addr < end; addr += PAGE_SIZE) { >> - ClearPageReserved(virt_to_page(addr)); >> - init_page_count(virt_to_page(addr)); >> memset((void *)addr, POISON_FREE_INITMEM, PAGE_SIZE); >> - free_page(addr); >> - totalram_pages++; >> + free_reserved_page(virt_to_page(addr)); >> } > > If I don't misread your code, avobe codes can replace to free_reserved_area() > as follow: > > free_reserved_area(addr, end, POISON_FREE_INITMEM, what) > > Am I wrong? Hi Yasuaki, Good catch, will enhance it in following patches. Thanks! > > Thanks, > Yasuaki Ishimatsu > >> #endif >> } >> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c >> index 474e28f..2ef81f1 100644 >> --- a/arch/x86/mm/init_64.c >> +++ b/arch/x86/mm/init_64.c >> @@ -1067,10 +1067,9 @@ void __init mem_init(void) >> >> /* clear_bss() already clear the empty_zero_page */ >> >> - reservedpages = 0; >> - >> - /* this will put all low memory onto the freelists */ >> register_page_bootmem_info(); >> + >> + /* this will put all memory onto the freelists */ >> totalram_pages = free_all_bootmem(); >> >> absent_pages = absent_pages_in_range(0, max_pfn); >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/