Date: Wed, 13 Mar 2013 10:57:45 -0700
From: Tejun Heo <tj@kernel.org>
To: Artem Savkov <artem.savkov@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
        Stephen Rothwell <sfr@canb.auug.org.au>, viakernel.org@htj.dyndns.org,
        linux-next@vger.kernel.org
Subject: Re: [PATCH] workqueue: missing idr_preload_end() in
 worker_pool_assign_id()
Message-ID: <20130313175745.GA22267@htj.dyndns.org>
References: <1363197092-4832-1-git-send-email-artem.savkov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1363197092-4832-1-git-send-email-artem.savkov@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 900
Lines: 28

(cc'ing Stephen and linux-next)

Hello, Artem.

On Wed, Mar 13, 2013 at 09:51:32PM +0400, Artem Savkov wrote:
> Added missing idr_preload_end() call in worker_pool_assign_id().
> Without it preemption stays disabled resulting in lots of "scheduling while
> atomic" BUGs during boot.
...
> Introduced in "workqueue: convert to idr_alloc()"

That patch doesn't use idr_preload().  It looks like the issue is
introduced during linux-next merge of wq/for-3.10 and idr patches in
-mm.  Stephen, can you please add idr_preload_end() to the merge
patch?

Once the idr patches land in Linus' tree, I'll resolve the conflict
from wq tree side.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/