Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933162Ab3CMSeg (ORCPT ); Wed, 13 Mar 2013 14:34:36 -0400 Received: from mail-bk0-f50.google.com ([209.85.214.50]:65327 "EHLO mail-bk0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755178Ab3CMSef (ORCPT ); Wed, 13 Mar 2013 14:34:35 -0400 Message-ID: <5140C6B2.7040702@gmail.com> Date: Wed, 13 Mar 2013 19:34:26 +0100 From: Daniel Mack User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 MIME-Version: 1.0 To: Jonas Jensen CC: linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, jirislaby@gmail.com, linux@arm.linux.org.uk, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: mach-moxart: platform port for MOXA ART SoC References: In-Reply-To: X-Enigmail-Version: undefined Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3847 Lines: 95 Hi Jonas, On 13.03.2013 16:37, Jonas Jensen wrote: > I ask for feedback and to submit (if possible) a new ARM SoC platform > port. This is now near complete (I think) (tested on UC-7112-LX Plus) > and applies to 2.6.34.14. First of all - thanks for submitting to the upstream kernel! However, your patch has many severe problems which you need to address. * please rebase your work. 2.6.34 is almost three years old now. 3.9 is in it's stabilisation phase, and all new support has to be done for 3.10. * all new platforms must be written with device-tree support * all drivers must have device-tree support as well > The patch contains the following drivers and platform specific implementations: > > * ARCH_MOXART (FA526 processor) > * 100Hz interrupt timer > * UART > * MTD map driver > * Ethernet driver (RTL8201CP) > * MMC driver > * MOXA Smartio/Industio family multiport serial driver > * RTC driver > * Watchdog driver > * GPIO driver Never send one big patch but series of smaller ones, so the individual subsystem maintainers can review and approve their bits. Please also read Documentation/SubmittingPatches for a lot more information about this subject. Best regards, Daniel > Predicted patch rejects below (in need of a solution, feedback is much > appreciated) because they are critical in areas of boot, MMC and TTY. > > arch/arm/boot/compressed/head.S: > A valid (and unique) architecture ID is not loaded to r1. Looks like > the bootloader is broken, it should be doing this! > http://gicl.cs.drexel.edu/people/sevy/linux/ARM_Linux_boot_sequence.html > > arch/arm/tools/mach-types: > Omitted (do not edit manually / add a new machine using > http://www.arm.linux.org.uk/developer/machines/?action=new). A fix to > this and above is not feasible as long as MOXA withholds bootloader > sources (requested without success). > > drivers/char/mxser.c drivers/char/mxser.h: MOXA > SMARTIO/INDUSTIO/INTELLIO SERIAL CARD (Jiří Slabý): > Force board setup for CONFIG_ARCH_MOXART. > ASYNCB_CLOSING is avoided because of a lockup (infinite wait after > tty_wait_until_sent). Why this happens is unknown (to me) I'm hoping > someone (Jiří?) can shed light. SysRq trace @ http://ideone.com/e845mr > What significance does ASYNCB_CLOSING have? > Obviously, automatic detection is better but "mxser_read_register" is > pointless on this hardware. What to do instead? Is it better to make a > copy and submit a new driver? > > drivers/mmc/core/sd.c: > The MMC controller is "special"? "UNSTUFF_BITS" is redefined here > http://repo.or.cz/w/linux-2.6.19-moxart.git/blob/50cdf2c57662f9f69c5615976412f76bfd73311a:/drivers/mmc/mmc.c > . Without the new macro it'll report the wrong geometry and prod_name. > I'm thinking a driver should never have to redefine UNSTUFF_BITS. > Possible workaround: modify bits (in driver) to line up as expected > before returning the response (mmc_request_done). > > > For reference, this is my previous post from a few months back: > http://lists.infradead.org/pipermail/linux-arm-kernel/2012-December/137130.html > > Gitweb: http://repo.or.cz/w/linux-2.6.34.14-moxart.git/commitdiff/?h=3bc2e98ebb92961e1c5992736186920cd070f4ee&hp=b7f1d43323eceb02fd663a71eb2f8be9c17e6740 > > Download link (size: 193K): > https://linux-2-6-34-14-moxart.googlecode.com/files/linux-2.6.34.14-moxart.patch > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/