Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933116Ab3CMSiF (ORCPT ); Wed, 13 Mar 2013 14:38:05 -0400 Received: from nbd.name ([46.4.11.11]:49701 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755178Ab3CMSiE (ORCPT ); Wed, 13 Mar 2013 14:38:04 -0400 Message-ID: <5140C77E.7030206@openwrt.org> Date: Wed, 13 Mar 2013 19:37:50 +0100 From: Felix Fietkau User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 MIME-Version: 1.0 To: Robin Holt CC: Sedat Dilek , Miklos Szeredi , viro@zeniv.linux.org.uk, torvalds@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, hch@infradead.org, akpm@linux-foundation.org, apw@canonical.com, neilb@suse.de, jordipujolp@gmail.com, ezk@fsl.cs.sunysb.edu, dhowells@redhat.com, sedat.dilek@googlemail.com, hooanon05@yahoo.co.jp, mszeredi@suse.cz Subject: Re: [PATCH 0/9] overlay filesystem: request for inclusion (v17) References: <1363184193-1796-1-git-send-email-miklos@szeredi.hu> <20130313181251.GA6023@sgi.com> In-Reply-To: <20130313181251.GA6023@sgi.com> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1532 Lines: 38 On 2013-03-13 7:12 PM, Robin Holt wrote: > On Wed, Mar 13, 2013 at 05:51:33PM +0100, Sedat Dilek wrote: >> On Wed, Mar 13, 2013 at 5:21 PM, Miklos Szeredi wrote: >> > On Wed, Mar 13, 2013 at 5:10 PM, Sedat Dilek wrote: >> > >> >> Anyway, with CONFIG_OVERLAYFS_FS=m I do not see any related messages >> >> when the kernel-module is loaded. >> >> So, is this intended? >> >> SquashFS prints into the logs, so what is it doing differently? >> > >> > Some modules do, some don't. It's not compulsory and not very useful. >> > >> >> What about... >> >> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c >> index 482c26f..92b9ad5 100644 >> --- a/fs/overlayfs/super.c >> +++ b/fs/overlayfs/super.c >> @@ -675,11 +675,13 @@ MODULE_ALIAS_FS("overlayfs"); >> static int __init ovl_init(void) >> { >> return register_filesystem(&ovl_fs_type); >> + printk(KERN_INFO "overlayfs: loaded\n"); > > How about pr_debug(). That makes things quite for most of us but gives > you info when looking for things like boot problems. How is having a printk/pr_debug useful here at all? The fact that other filesystems do this as well is not a good reason... Also, putting it *after* the return statement doesn't make much sense ;) - Felix -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/