Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934183Ab3CMToi (ORCPT ); Wed, 13 Mar 2013 15:44:38 -0400 Received: from mail-wg0-f52.google.com ([74.125.82.52]:57000 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932709Ab3CMTog (ORCPT ); Wed, 13 Mar 2013 15:44:36 -0400 Message-ID: <1363203873.15011.311.camel@mfleming-mobl1.ger.corp.intel.com> Subject: Re: [PATCH] efivars: Allow disabling use as a pstore backend From: Matt Fleming To: Seth Forshee Cc: "H. Peter Anvin" , Matthew Garrett , linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Date: Wed, 13 Mar 2013 19:44:33 +0000 In-Reply-To: <20130313191455.GC12157@thinkpad-t410> References: <20130307205915.GF24233@thinkpad-t410> <1362694529.15011.211.camel@mfleming-mobl1.ger.corp.intel.com> <513911F9.8050308@zytor.com> <20130311211750.GB8440@thinkpad-t410> <1363118073.15011.275.camel@mfleming-mobl1.ger.corp.intel.com> <20130312211417.GC16558@thinkpad-t410> <1363189770.15011.300.camel@mfleming-mobl1.ger.corp.intel.com> <20130313170724.GB12157@thinkpad-t410> <5140B674.8070308@zytor.com> <1363199617.15011.310.camel@mfleming-mobl1.ger.corp.intel.com> <20130313191455.GC12157@thinkpad-t410> Organization: Intel Corporation (UK) Ltd. - Registered No. 1134945 - Pipers Way, Swindon SN3 1RJ Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4 (3.4.4-2.fc17) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1024 Lines: 28 On Wed, 2013-03-13 at 14:14 -0500, Seth Forshee wrote: > On Wed, Mar 13, 2013 at 06:33:37PM +0000, Matt Fleming wrote: > > On Wed, 2013-03-13 at 10:25 -0700, H. Peter Anvin wrote: > > > I think there should be two compile-time options (one to compile in the > > > EFI pstore code at all, and one to set its default.) > > > > OK, sorry Seth, looks like I'm the one that misunderstood. I've picked > > up your first two patches and pushed them out to the urgent branch. > > Please check that they look OK - they required minor fixups. > > A minor nit from the second patch: > > +static bool efivars_pstore_disable = \ > + IS_ENABLED(EFI_VARS_PSTORE_DEFAULT_DISABLE); > > The backslash isn't necessary. Whoops. Fixed. > Otherwise everything looks fine afaict. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/