Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934294Ab3CMUwj (ORCPT ); Wed, 13 Mar 2013 16:52:39 -0400 Received: from mail-la0-f43.google.com ([209.85.215.43]:55765 "EHLO mail-la0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933178Ab3CMUwh (ORCPT ); Wed, 13 Mar 2013 16:52:37 -0400 MIME-Version: 1.0 In-Reply-To: <1363147700-7042-1-git-send-email-ch.naveen@samsung.com> References: <1363077566-6254-1-git-send-email-ch.naveen@samsung.com> <1363147700-7042-1-git-send-email-ch.naveen@samsung.com> Date: Wed, 13 Mar 2013 13:52:35 -0700 X-Google-Sender-Auth: MwcHJjo4iwF9X3E2qKeg97dUNQk Message-ID: Subject: Re: [PATCH v4] hwmon: ntc: Add DT with IIO support to NTC thermistor driver From: Doug Anderson To: Naveen Krishna Chatradhi Cc: "linux-kernel@vger.kernel.org" , lm-sensors@lm-sensors.org, devicetree-discuss@lists.ozlabs.org, Jean Delvare , Guenter Roeck , Naveen Krishna Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1659 Lines: 42 Hi, On Tue, Mar 12, 2013 at 9:08 PM, Naveen Krishna Chatradhi wrote: > This patch adds DT support to NTC driver to parse the > platform data. > > Also adds the support to work as an iio device. > > During the probe ntc driver gets the respective channels of ADC > and uses iio_raw_read calls to get the ADC converted value. > > Signed-off-by: Naveen Krishna Chatradhi > --- > Changes since v3: > 1. Added a NULL check before iio_channel_release > 2. Modified a return statement > > Guenter Roeck, Its wonderful working with you. Thanks. > > .../devicetree/bindings/hwmon/ntc_thermistor.txt | 29 ++++ > drivers/hwmon/Kconfig | 1 + > drivers/hwmon/ntc_thermistor.c | 145 +++++++++++++++++--- > include/linux/platform_data/ntc_thermistor.h | 8 +- > 4 files changed, 163 insertions(+), 20 deletions(-) I haven't done a full review of this code, but it I built it in (along with other CLs to enable it on exynos5250-snow) and the thermistors are accessible and report reasonable values. localhost hwmon # grep "" /sys/class/hwmon/*/device/temp1_input /sys/class/hwmon/hwmon0/device/temp1_input:37890 /sys/class/hwmon/hwmon1/device/temp1_input:38393 /sys/class/hwmon/hwmon2/device/temp1_input:37148 /sys/class/hwmon/hwmon3/device/temp1_input:38059 Tested-by: Doug Anderson -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/