Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934349Ab3CNDiv (ORCPT ); Wed, 13 Mar 2013 23:38:51 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:36385 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756572Ab3CNDit (ORCPT ); Wed, 13 Mar 2013 23:38:49 -0400 MIME-Version: 1.0 In-Reply-To: <1363219179-14900-1-git-send-email-agraf@suse.de> References: <1363219179-14900-1-git-send-email-agraf@suse.de> Date: Wed, 13 Mar 2013 20:38:47 -0700 X-Google-Sender-Auth: taW999RHok6g84cxG1R2N_GoK8U Message-ID: Subject: Re: [PATCH v2] USB: ehci-s5p: Fix phy reset From: Doug Anderson To: Alexander Graf Cc: "linux-kernel@vger.kernel.org" , linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org, dmueller@suse.de, Vivek Gautam , Jingoo Han , Alan Stern , Kukjin Kim , Felipe Balbi , Greg Kroah-Hartman Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1725 Lines: 49 Alexander, On Wed, Mar 13, 2013 at 4:59 PM, Alexander Graf wrote: > On my Exynos 5 based Arndale system, I need to pull the reset line down > and then let it go up again to actually perform a reset. Without that > reset, I can't find any USB hubs on my bus, rendering the USB controller > useless. > > We also only need to reset the line after the phy node has been found. > This way we don't accidently reserve the vbus GPIO pin, but later on > defer the creation of our controller, because the phy device tree node > hasn't been probed yet. > > This patch implements the above logic, making EHCI and OHCI work on > Arndale systems for me. > > Signed-off-by: Alexander Graf > CC: Vivek Gautam > CC: Jingoo Han > CC: Alan Stern > CC: Kukjin Kim > CC: Felipe Balbi > CC: Greg Kroah-Hartman > CC: Doug Anderson > > --- > > v1 -> v2: > > - remove gpio_free call > - move reset logic after phy node search Seems fine to me. I guess the earlier problem you wrote about was the probe failure, then? I think that the reason I don't tend to get the probe failure is that I've got my device tree ordered differently so that the phy gets initted in a different order. I'll send up the devm_ patch atop this. Reviewed-by: Doug Anderson Thanks! :) -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/