Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751451Ab3CNIB1 (ORCPT ); Thu, 14 Mar 2013 04:01:27 -0400 Received: from mail-ia0-f176.google.com ([209.85.210.176]:64824 "EHLO mail-ia0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009Ab3CNIB0 (ORCPT ); Thu, 14 Mar 2013 04:01:26 -0400 MIME-Version: 1.0 In-Reply-To: References: <20130305003219.14792.13300.sendpatchset@w520> Date: Thu, 14 Mar 2013 09:01:25 +0100 Message-ID: Subject: Re: [PATCH] gpio: Renesas R-Car GPIO driver From: Linus Walleij To: Magnus Damm Cc: linux-kernel@vger.kernel.org, grant.likely@secretlab.ca, horms@verge.net.au, linux-sh@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 764 Lines: 19 On Thu, Mar 14, 2013 at 5:07 AM, Magnus Damm wrote: > On Thu, Mar 14, 2013 at 2:20 AM, Linus Walleij wrote: >> It is quite common to request IRQ on *both* rising and falling edges, >> what happens then? (...) > I may be wrong, but the switch above does AND with IRQ_TYPE_SENSE_MASK > which makes me believe that the BOTH case will result in -EINVAL. Yes you're right, I wasn't quite following. The code only allows for one distinct flag, fine! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/