Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757029Ab3CNMKR (ORCPT ); Thu, 14 Mar 2013 08:10:17 -0400 Received: from mail-bk0-f48.google.com ([209.85.214.48]:39679 "EHLO mail-bk0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750989Ab3CNMKP (ORCPT ); Thu, 14 Mar 2013 08:10:15 -0400 MIME-Version: 1.0 In-Reply-To: <20130314105155.GG32369@arwen.pp.htv.fi> References: <1363257898-17504-1-git-send-email-gautam.vivek@samsung.com> <1363257898-17504-2-git-send-email-gautam.vivek@samsung.com> <20130314105155.GG32369@arwen.pp.htv.fi> Date: Thu, 14 Mar 2013 17:40:12 +0530 Message-ID: Subject: Re: [PATCH 1/2] usb: dwc3: exynos: Use of_platform API to create dwc3 core pdev From: Vivek Gautam To: balbi@ti.com Cc: Vivek Gautam , linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, gregkh@linuxfoundation.org, rob.herring@calxeda.com, kgene.kim@samsung.com, thomas.abraham@linaro.org, dianders@chromium.org, Kishon Vijay Abraham I Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1034 Lines: 41 On Thu, Mar 14, 2013 at 4:21 PM, Felipe Balbi wrote: > Hi, > > On Thu, Mar 14, 2013 at 04:14:57PM +0530, Vivek Gautam wrote: >> @@ -170,7 +155,6 @@ static int dwc3_exynos_remove(struct platform_device *pdev) >> { >> struct dwc3_exynos *exynos = platform_get_drvdata(pdev); >> >> - platform_device_unregister(exynos->dwc3); > > don't you want to do what Kishon did here and have: > > static int dwc3_exynos_remove_child(struct device *dev, void *unused) > { > struct platform_device *pdev = to_platform_device(dev); > > platform_device_unregister(pdev); > > return 0; > } > > device_for_each_child(&pdev->dev, NULL, dwc3_exynos_remove_child); > > ??? Hmm, right. We need to do that. :-) > > -- > balbi -- Thanks & Regards Vivek -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/