Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757860Ab3CNN1J (ORCPT ); Thu, 14 Mar 2013 09:27:09 -0400 Received: from moutng.kundenserver.de ([212.227.126.186]:59699 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755776Ab3CNN1G (ORCPT ); Thu, 14 Mar 2013 09:27:06 -0400 Date: Thu, 14 Mar 2013 14:25:46 +0100 (CET) From: Guennadi Liakhovetski X-X-Sender: lyakh@axis700.grange To: Fabio Porcedda cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-ide@vger.kernel.org, lm-sensors@lm-sensors.org, linux-input@vger.kernel.org, linux-fbdev@vger.kernel.org, Greg Kroah-Hartman , Mauro Carvalho Chehab , Josh Wu , Hans Verkuil Subject: Re: [PATCH 01/10] drivers: media: use module_platform_driver_probe() In-Reply-To: <1363266691-15757-2-git-send-email-fabio.porcedda@gmail.com> Message-ID: References: <1363266691-15757-1-git-send-email-fabio.porcedda@gmail.com> <1363266691-15757-2-git-send-email-fabio.porcedda@gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Provags-ID: V02:K0:G97ALUOojaqJgEPB16EosvpCicsXi2GLUg7jzDS9ul4 EmzNMec92HxN0Dmh5YyZSBdgoMWLjAu6CimBtpnYw+wqrVOsoA xajRPl4ys30xgmvphBfNkgUKKKfdyJVV/viY4uLR6ZAoNJRjKA oRf0nCAyqOfIwp7Lm/XzwteUV5j7hILkZCpy/zxcZAzqnO998K wZuCql/E4Qvm4VFB5nfiGu60sEX6bNNiadgEn2Swgdopz/8elO geT0nkst3OqwkOoNR/BtpL3Nle+sxZ2P13jpsjH0G9A0OoYS2N TMk7mPKrNXxxLGLuqCXX0nxc4kZ6iHjFGhiOg1yFu/tU8UU4Ti LwQWRp/naQRTkzKWOPB+qoTZyZp4CdNpsaTO1UnFeWZAYacmch anSW4SIzoyzFA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3802 Lines: 113 Hi Fabio On Thu, 14 Mar 2013, Fabio Porcedda wrote: > This patch converts the drivers to use the > module_platform_driver_probe() macro which makes the code smaller and > a bit simpler. > > Signed-off-by: Fabio Porcedda > Cc: Greg Kroah-Hartman > Cc: Mauro Carvalho Chehab > Cc: Josh Wu > Cc: Guennadi Liakhovetski > Cc: Hans Verkuil > Cc: linux-media@vger.kernel.org Thanks for the patch. Subtracting this series http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/61403 you only need to convert atmel-isi.c. Please, respin. Thanks Guennadi > --- > drivers/media/platform/sh_vou.c | 13 +------------ > drivers/media/platform/soc_camera/atmel-isi.c | 12 +----------- > drivers/media/platform/soc_camera/mx1_camera.c | 13 +------------ > 3 files changed, 3 insertions(+), 35 deletions(-) > > diff --git a/drivers/media/platform/sh_vou.c b/drivers/media/platform/sh_vou.c > index 66c8da1..d853162 100644 > --- a/drivers/media/platform/sh_vou.c > +++ b/drivers/media/platform/sh_vou.c > @@ -1485,18 +1485,7 @@ static struct platform_driver __refdata sh_vou = { > }, > }; > > -static int __init sh_vou_init(void) > -{ > - return platform_driver_probe(&sh_vou, sh_vou_probe); > -} > - > -static void __exit sh_vou_exit(void) > -{ > - platform_driver_unregister(&sh_vou); > -} > - > -module_init(sh_vou_init); > -module_exit(sh_vou_exit); > +module_platform_driver_probe(sh_vou, sh_vou_probe); > > MODULE_DESCRIPTION("SuperH VOU driver"); > MODULE_AUTHOR("Guennadi Liakhovetski "); > diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b/drivers/media/platform/soc_camera/atmel-isi.c > index 82dbf99..12ba31d 100644 > --- a/drivers/media/platform/soc_camera/atmel-isi.c > +++ b/drivers/media/platform/soc_camera/atmel-isi.c > @@ -1081,17 +1081,7 @@ static struct platform_driver atmel_isi_driver = { > }, > }; > > -static int __init atmel_isi_init_module(void) > -{ > - return platform_driver_probe(&atmel_isi_driver, &atmel_isi_probe); > -} > - > -static void __exit atmel_isi_exit(void) > -{ > - platform_driver_unregister(&atmel_isi_driver); > -} > -module_init(atmel_isi_init_module); > -module_exit(atmel_isi_exit); > +module_platform_driver_probe(atmel_isi_driver, atmel_isi_probe); > > MODULE_AUTHOR("Josh Wu "); > MODULE_DESCRIPTION("The V4L2 driver for Atmel Linux"); > diff --git a/drivers/media/platform/soc_camera/mx1_camera.c b/drivers/media/platform/soc_camera/mx1_camera.c > index 25b2a28..4389f43 100644 > --- a/drivers/media/platform/soc_camera/mx1_camera.c > +++ b/drivers/media/platform/soc_camera/mx1_camera.c > @@ -859,18 +859,7 @@ static struct platform_driver mx1_camera_driver = { > .remove = __exit_p(mx1_camera_remove), > }; > > -static int __init mx1_camera_init(void) > -{ > - return platform_driver_probe(&mx1_camera_driver, mx1_camera_probe); > -} > - > -static void __exit mx1_camera_exit(void) > -{ > - return platform_driver_unregister(&mx1_camera_driver); > -} > - > -module_init(mx1_camera_init); > -module_exit(mx1_camera_exit); > +module_platform_driver_probe(mx1_camera_driver, mx1_camera_probe); > > MODULE_DESCRIPTION("i.MX1/i.MXL SoC Camera Host driver"); > MODULE_AUTHOR("Paulius Zaleckas "); > -- > 1.8.1.5 > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/