Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964818Ab3CNPoa (ORCPT ); Thu, 14 Mar 2013 11:44:30 -0400 Received: from mail-wg0-f48.google.com ([74.125.82.48]:64663 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933550Ab3CNPo2 (ORCPT ); Thu, 14 Mar 2013 11:44:28 -0400 From: Peter Korsgaard To: Sekhar Nori Cc: Philip Avinash , davinci-linux-open-source@linux.davincidsp.com, linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, Rob Herring , prakash.pm@ti.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/3] pwm: pwm-tiecap: Add device-tree binding support for da850 SOC References: <1363257158-11615-1-git-send-email-avinashphilip@ti.com> <1363257158-11615-3-git-send-email-avinashphilip@ti.com> <5141B7CC.7000700@ti.com> Date: Thu, 14 Mar 2013 16:44:23 +0100 In-Reply-To: <5141B7CC.7000700@ti.com> (Sekhar Nori's message of "Thu, 14 Mar 2013 17:13:08 +0530") Message-ID: <87txoe56lk.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1481 Lines: 37 >>>>> "Sekhar" == Sekhar Nori writes: >> Required properties: >> -- compatible: Must be "ti,am33xx-ecap" >> +- compatible: Must be "ti,am33xx-ecap" or "ti,da850-ecap" >> - #pwm-cells: Should be 3. Number of cells being used to specify PWM property. >> First cell specifies the per-chip index of the PWM to use, the second >> cell is the period in nanoseconds and bit 0 in the third cell is used to >> diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c >> index 22e96e2..e0d96c8 100644 >> --- a/drivers/pwm/pwm-tiecap.c >> +++ b/drivers/pwm/pwm-tiecap.c >> @@ -197,6 +197,7 @@ static const struct pwm_ops ecap_pwm_ops = { >> >> static const struct of_device_id ecap_of_match[] = { >> { .compatible = "ti,am33xx-ecap" }, >> + { .compatible = "ti,da850-ecap" }, >> {}, Sekhar> You add a new compatible, but don't really show any changes in Sekhar> driver in this series. So why can't we simply use Sekhar> ti,am33xx-ecap on DA850 too? Indeed, if the hardware block is identical the dts should simply list: compatible = "ti,da850-ecap", "ti,am33xx-ecap" And the driver only bind to ti,am33xx-ecap (unless there ever needs to be a da850 specific workarounde. -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/