Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751763Ab3CNUCK (ORCPT ); Thu, 14 Mar 2013 16:02:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37476 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751363Ab3CNUCI (ORCPT ); Thu, 14 Mar 2013 16:02:08 -0400 Date: Thu, 14 Mar 2013 16:00:54 -0400 From: Dave Jones To: "Paul E. McKenney" Cc: Li Zefan , Sasha Levin , ebiederm@xmission.com, Eric Dumazet , CAI Qian , linux-kernel , Containers Subject: Re: 3.9-rc1 NULL pointer crash at find_pid_ns Message-ID: <20130314200054.GA5924@redhat.com> Mail-Followup-To: Dave Jones , "Paul E. McKenney" , Li Zefan , Sasha Levin , ebiederm@xmission.com, Eric Dumazet , CAI Qian , linux-kernel , Containers References: <513860E8.4080807@huawei.com> <876213wmwt.fsf@xmission.com> <5138D001.8000409@oracle.com> <1362678371.15793.218.camel@edumazet-glaptop> <5138D377.6040406@oracle.com> <87boavrspd.fsf@xmission.com> <5138D8F2.5020900@oracle.com> <20130307182934.GY3268@linux.vnet.ibm.com> <513AEC65.8000008@huawei.com> <20130309155146.GR3268@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130309155146.GR3268@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 941 Lines: 27 On Sat, Mar 09, 2013 at 07:51:46AM -0800, Paul E. McKenney wrote: > On Sat, Mar 09, 2013 at 04:01:41PM +0800, Li Zefan wrote: > > [ . . . ] > > > > This way, "ptr" is executed exactly once, and the check and the > > > hlist_entry() are both using the same value. > > > > I just played with trinity, and triggered this bug in just a few mins, > > and I tried Paul's proposed fix and it works. > > Thank you for testing this! Please see below for the patch. > > Sasha, will you be pushing this or would you like me to do so? [crickets] Given this has been hanging for the better part of another week, Paul why not send it Linus so hopefully rc3 doesn't have this bug ? Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/