Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751148Ab3COEkq (ORCPT ); Fri, 15 Mar 2013 00:40:46 -0400 Received: from e31.co.us.ibm.com ([32.97.110.149]:39461 "EHLO e31.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750706Ab3COEkp (ORCPT ); Fri, 15 Mar 2013 00:40:45 -0400 Date: Fri, 15 Mar 2013 10:10:00 +0530 From: Ananth N Mavinakayanahalli To: Masami Hiramatsu Cc: Ingo Molnar , Linus Torvalds , linux-kernel@vger.kernel.org, Timo Juhani Lindfors , Pavel Emelyanov , Jiri Kosina , Ingo Molnar , Nadia Yvette Chambers , yrl.pp-manager.tt@hitachi.com, "David S. Miller" Subject: Re: [PATCH -tip v2 1/2] [BUGFIX] kprobes: make hash_64() as always inlined Message-ID: <20130315044000.GB31866@in.ibm.com> Reply-To: ananth@in.ibm.com References: <20130314115230.19690.39387.stgit@mhiramat-M0-7522> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130314115230.19690.39387.stgit@mhiramat-M0-7522> User-Agent: Mutt/1.5.17 (2007-11-01) X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13031504-7282-0000-0000-0000152F1483 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1283 Lines: 32 On Thu, Mar 14, 2013 at 08:52:30PM +0900, Masami Hiramatsu wrote: > Because hash_64() is called from the get_kprobe() inside > int3 handler, kernel causes int3 recursion and crashes if > kprobes user puts a probe on it. > > Usually hash_64() is inlined into caller function, but in > some cases, it has instances by gcc's interprocedural > constant propagation. > > This patch uses __always_inline instead of inline to > prevent gcc from doing such things. > > Changes in v2: > - Use __always_inline instead of using __kprobes > > Signed-off-by: Masami Hiramatsu > Reported-by: Timo Juhani Lindfors > Cc: "David S. Miller" > Cc: Nadia Yvette Chambers > Cc: Pavel Emelyanov > Cc: Jiri Kosina > Cc: Ananth N Mavinakayanahalli > Cc: Ingo Molnar > Cc: Linus Torvalds Acked-by: Ananth N Mavinakayanahalli -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/