Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753522Ab3COHox (ORCPT ); Fri, 15 Mar 2013 03:44:53 -0400 Received: from mail-ob0-f172.google.com ([209.85.214.172]:44855 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753023Ab3COHov (ORCPT ); Fri, 15 Mar 2013 03:44:51 -0400 MIME-Version: 1.0 In-Reply-To: <1363283435-7666-26-git-send-email-kirill.shutemov@linux.intel.com> References: <1363283435-7666-1-git-send-email-kirill.shutemov@linux.intel.com> <1363283435-7666-26-git-send-email-kirill.shutemov@linux.intel.com> Date: Fri, 15 Mar 2013 15:44:50 +0800 Message-ID: Subject: Re: [PATCHv2, RFC 25/30] thp, mm: basic huge_fault implementation for generic_file_vm_ops From: Hillf Danton To: "Kirill A. Shutemov" Cc: Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1330 Lines: 33 On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov wrote: > > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > +static int filemap_huge_fault(struct vm_area_struct *vma, struct vm_fault *vmf) > +{ > + struct file *file = vma->vm_file; > + struct address_space *mapping = file->f_mapping; > + struct inode *inode = mapping->host; > + pgoff_t size, offset = vmf->pgoff; > + unsigned long address = (unsigned long) vmf->virtual_address; > + struct page *page; > + int ret = 0; > + > + BUG_ON(((address >> PAGE_SHIFT) & HPAGE_CACHE_INDEX_MASK) != > + (offset & HPAGE_CACHE_INDEX_MASK)); > + > +retry: > + page = find_get_page(mapping, offset); > + if (!page) { > + gfp_t gfp_mask = mapping_gfp_mask(mapping) | __GFP_COLD; > + page = alloc_pages(gfp_mask, HPAGE_PMD_ORDER); s/pages/pages_vma/ ? > + if (!page) { > + count_vm_event(THP_FAULT_FALLBACK); > + return VM_FAULT_OOM; > + } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/