Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755247Ab3CONXF (ORCPT ); Fri, 15 Mar 2013 09:23:05 -0400 Received: from mga11.intel.com ([192.55.52.93]:1119 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754173Ab3CONXD (ORCPT ); Fri, 15 Mar 2013 09:23:03 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,850,1355126400"; d="scan'208";a="303416350" From: "Kirill A. Shutemov" To: Hillf Danton Cc: "Kirill A. Shutemov" , Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: References: <1363283435-7666-1-git-send-email-kirill.shutemov@linux.intel.com> <1363283435-7666-14-git-send-email-kirill.shutemov@linux.intel.com> Subject: Re: [PATCHv2, RFC 13/30] thp, mm: implement grab_cache_huge_page_write_begin() Content-Transfer-Encoding: 7bit Message-Id: <20130315132440.C4DF8E0085@blue.fi.intel.com> Date: Fri, 15 Mar 2013 15:24:40 +0200 (EET) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 875 Lines: 29 Hillf Danton wrote: > On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov > wrote: > > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > > +struct page *grab_cache_huge_page_write_begin(struct address_space *mapping, > > + pgoff_t index, unsigned flags); > > +#else > > +static inline struct page *grab_cache_huge_page_write_begin( > > + struct address_space *mapping, pgoff_t index, unsigned flags) > > +{ > build bug? Hm?. No. Why? > > + return NULL; > > +} > > +#endif > > > btw, how about grab_thp_write_begin? Sounds better, thanks. -- Kirill A. Shutemov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/