Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755319Ab3CONdh (ORCPT ); Fri, 15 Mar 2013 09:33:37 -0400 Received: from mail-oa0-f43.google.com ([209.85.219.43]:58513 "EHLO mail-oa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754763Ab3CONde (ORCPT ); Fri, 15 Mar 2013 09:33:34 -0400 MIME-Version: 1.0 In-Reply-To: <20130315132656.BC518E0085@blue.fi.intel.com> References: <1363283435-7666-1-git-send-email-kirill.shutemov@linux.intel.com> <1363283435-7666-17-git-send-email-kirill.shutemov@linux.intel.com> <20130315132656.BC518E0085@blue.fi.intel.com> Date: Fri, 15 Mar 2013 21:33:34 +0800 Message-ID: Subject: Re: [PATCHv2, RFC 16/30] thp: handle file pages in split_huge_page() From: Hillf Danton To: "Kirill A. Shutemov" Cc: Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 917 Lines: 25 On Fri, Mar 15, 2013 at 9:26 PM, Kirill A. Shutemov wrote: > Hillf Danton wrote: >> On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov >> wrote: >> > -int split_huge_page(struct page *page) >> > +static int split_anon_huge_page(struct page *page) >> > { >> > struct anon_vma *anon_vma; >> > int ret = 1; >> > >> > - BUG_ON(is_huge_zero_pfn(page_to_pfn(page))); >> > - BUG_ON(!PageAnon(page)); >> > - >> deleted, why? > > split_anon_huge_page() should only be called from split_huge_page(). > Probably I could bring it back, but it's kinda redundant. > Ok, no more question. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/