Subject: Re: [PATCH] powerpc/qe: remove useless Kconfig default
Mime-Version: 1.0 (Apple Message framework v1278)
Content-Type: text/plain; charset=us-ascii
From: Kumar Gala <galak@kernel.crashing.org>
In-Reply-To: <1363124951.3137.156.camel@x61.thuisdomein>
Date: Fri, 15 Mar 2013 11:16:38 -0500
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>, linuxppc-dev@lists.ozlabs.org,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8BIT
Message-Id: <61AABF0B-0F3F-4E85-98F8-4445E469EE86@kernel.crashing.org>
References: <1363124951.3137.156.camel@x61.thuisdomein>
To: Paul Bolle <pebolle@tiscali.nl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1241
Lines: 35


On Mar 12, 2013, at 4:49 PM, Paul Bolle wrote:

> The Kconfig entry for QE_USB contains
> 	default y if USB_GADGET_FSL_QE
> 
> But USB_GADGET_FSL_QE got removed in commit
> 193ab2a6070039e7ee2b9b9bebea754a7c52fd1b ("usb: gadget: allow multiple
> gadgets to be built"). This default will therefor never be set and can
> be removed.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Tested with "make ARCH=powerpc menuconfig" and "make ARCH=powerpc
> oldconfig" (before and after the patch). Enough to see this patch didn't
> obviously break stuff.
> 
> 1) I don't really understand commit
> 193ab2a6070039e7ee2b9b9bebea754a7c52fd1b. Was its point that we replace
> USB_GADGET_FSL_QE with USB_FSL_QE? I couldn't tell and chose not to
> actually change any behavior.
> 
> arch/powerpc/sysdev/qe_lib/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
> 

You're correct that this isn't quite right, I've posted a proper patch that should fix this correctly.

thanks for pointing it out.

- k--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/