Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755386Ab3CORBw (ORCPT ); Fri, 15 Mar 2013 13:01:52 -0400 Received: from mail-vb0-f52.google.com ([209.85.212.52]:65476 "EHLO mail-vb0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755324Ab3CORBv (ORCPT ); Fri, 15 Mar 2013 13:01:51 -0400 MIME-Version: 1.0 In-Reply-To: <20130315132607.GA4565@quad> References: <20130315132607.GA4565@quad> Date: Fri, 15 Mar 2013 10:01:50 -0700 X-Google-Sender-Auth: -2GA8pIDHML4dgdu_4gIIKcggns Message-ID: Subject: Re: [PATCH] perf,x86: fix kernel crash with PEBS/BTS after suspend/resume From: Linus Torvalds To: Stephane Eranian Cc: Linux Kernel Mailing List , Peter Zijlstra , Ingo Molnar , Thomas Gleixner , Andrew Morton , Arnaldo Carvalho de Melo , Jiri Olsa , Andi Kleen Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 834 Lines: 22 On Fri, Mar 15, 2013 at 6:26 AM, Stephane Eranian wrote: > > This patch fixes a kernel crash when using precise sampling (PEBS) > after a suspend/resume. Yup, works. Applied. Can we please get rid of the crazy CPU notifier crap from the perf code, and do this like we do most other wrmsr's etc? Doing git grep "case CPU_" arch/x86/kernel/cpu shows that the perf layer seems to be full of this kind of BS. This is all CPU state, it should be initialized by the regular CPU initialization code, not hooked up with some random callbacks. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/