Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932259Ab3COUTD (ORCPT ); Fri, 15 Mar 2013 16:19:03 -0400 Received: from moutng.kundenserver.de ([212.227.126.186]:56804 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754856Ab3COUTA (ORCPT ); Fri, 15 Mar 2013 16:19:00 -0400 From: Arnd Bergmann To: H Hartley Sweeten Subject: Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe() Date: Fri, 15 Mar 2013 20:18:08 +0000 User-Agent: KMail/1.12.2 (Linux/3.8.0-8-generic; KDE/4.3.2; x86_64; ; ) Cc: Fabio Porcedda , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" , "linux-ide@vger.kernel.org" , "lm-sensors@lm-sensors.org" , "linux-input@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "Greg Kroah-Hartman" , "Hans-Christian Egtvedt" , Grant Likely References: <1363266691-15757-1-git-send-email-fabio.porcedda@gmail.com> <201303141358.05616.arnd@arndb.de> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201303152018.09094.arnd@arndb.de> X-Provags-ID: V02:K0:aCc15neEDS50y3S5YBE5itPp1Uw6+JCvQ0aoukTSFIe w1NIrOS8Rjvr3gWouY/IPRX9AzcxGS4oLicrnhp+xpLIwGrS9O kAC31gW2MUfRLGMaFabqrZ3ouKz+K7UNJ2uAlt54TsEEaYwvuZ RAhok8rkZxB4io0FjP/Xj9f0jLL29uPHaGKPKQqTmV5x/TRCS/ zGCDdTYx4NkPe3ZHRuvWZnuiiY8LlJwdWEGDsk5YSL3reCEXY/ lrkAQdygFNQWG8wImlnghe/OlcQnv71ZnFdid+BjHmL7ffjA0J kZqp/eIAk3gYaXCWlsuoVpf9h89fxEMyDrJlZAwrH7NC8Ex6G1 nuvf5//W3YRD1S0Rzx30= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1430 Lines: 30 On Friday 15 March 2013, H Hartley Sweeten wrote: > Arnd, > > Ill look at converting the ep93xx pwm driver to the PWM subsystem. The only issue is > the current driver exposes a sysfs interface that I think is not available in that subsystem. You can probably keep providing that interface if you have active users. > >* Regarding the use of module_platform_driver_probe, I'm a little worried about > > the interactions with deferred probing. I don't think there are any regressions, > > but we should probably make people aware that one cannot return -EPROBE_DEFER > > from a platform_driver_probe function. > > The ep93xx pwm driver does not need to use platform_driver_probe(). It can be changed > to use module_platform_driver() by just moving the .probe to the platform_driver. This > driver was added before module_platform_driver() was available and I used the > platform_driver_probe() thinking it would save a couple lines of code. > > I'll change this in a bit. Right now I'm trying to work out why kernel 3.8 is not booting > on the ep93xx. I had 3.6.6 on my development board and 3.7 works fine but 3.8 hangs > without uncompressing the kernel. Ok, thanks! Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/