Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932411Ab3CPNLN (ORCPT ); Sat, 16 Mar 2013 09:11:13 -0400 Received: from mail-vc0-f172.google.com ([209.85.220.172]:48860 "EHLO mail-vc0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932125Ab3CPNLL (ORCPT ); Sat, 16 Mar 2013 09:11:11 -0400 Date: Sat, 16 Mar 2013 09:11:06 -0400 From: Konrad Rzeszutek Wilk To: Wanpeng Li Cc: Greg Kroah-Hartman , Andrew Morton , Dan Magenheimer , Seth Jennings , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/5] handle zcache_[eph|pers]_zpages for zero-filled page Message-ID: <20130316131104.GE5987@konrad-lan.dumpdata.com> References: <1363314860-22731-1-git-send-email-liwanp@linux.vnet.ibm.com> <1363314860-22731-4-git-send-email-liwanp@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1363314860-22731-4-git-send-email-liwanp@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1922 Lines: 51 On Fri, Mar 15, 2013 at 10:34:18AM +0800, Wanpeng Li wrote: > Increment/decrement zcache_[eph|pers]_zpages for zero-filled pages, > the main point of the counters for zpages and pageframes is to be > able to calculate density == zpages/pageframes. A zero-filled page > becomes a zpage that "compresses" to zero bytes and, as a result, > requires zero pageframes for storage. So the zpages counter should > be increased but the pageframes counter should not. > > [Dan Magenheimer : patch description] > Acked-by: Dan Magenheimer Reviewed-by: Konrad Rzeszutek Wilk > Signed-off-by: Wanpeng Li > --- > drivers/staging/zcache/zcache-main.c | 7 ++++++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/zcache/zcache-main.c b/drivers/staging/zcache/zcache-main.c > index 6c35c7d..ef8c960 100644 > --- a/drivers/staging/zcache/zcache-main.c > +++ b/drivers/staging/zcache/zcache-main.c > @@ -863,6 +863,8 @@ static int zcache_pampd_get_data_and_free(char *data, size_t *sizep, bool raw, > if (pampd == (void *)ZERO_FILLED) { > handle_zero_filled_page(data); > zero_filled = true; > + zsize = 0; > + zpages = 1; > if (!raw) > *sizep = PAGE_SIZE; > goto zero_fill; > @@ -917,8 +919,11 @@ static void zcache_pampd_free(void *pampd, struct tmem_pool *pool, > > BUG_ON(preemptible()); > > - if (pampd == (void *)ZERO_FILLED) > + if (pampd == (void *)ZERO_FILLED) { > zero_filled = true; > + zsize = 0; > + zpages = 1; > + } > > if (pampd_is_remote(pampd) && !zero_filled) { > > -- > 1.7.7.6 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/