From: Martin Walch <walch.martin@web.de>
To: linux-kernel@vger.kernel.org
Subject: RAMster selects HAVE_ALIGNED_STRUCT_PAGE on 64 bit systems when it should not
Date: Sat, 16 Mar 2013 20:35:59 +0100
Message-ID: <1577953.rJTZvHtihu@tacticalops>
User-Agent: KMail/4.10.1 (Linux/3.7.10-gentoo-gnu; KDE/4.10.1; x86_64; ; )
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart5173705.3zXMljTsZa"; micalg="pgp-sha1"; protocol="application/pgp-signature"
Content-Transfer-Encoding: 7Bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1641
Lines: 50


--nextPart5173705.3zXMljTsZa
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"

At drivers/staging/zcache/Kconfig:13 it says

config RAMSTER
	bool "Cross-machine RAM capacity sharing, aka peer-to-peer tmem"
	depends on CONFIGFS_FS=y && SYSFS=y && !HIGHMEM && ZCACHE=y
	depends on NET
	# must ensure struct page is 8-byte aligned
	select HAVE_ALIGNED_STRUCT_PAGE if !64_BIT
	default n

However, there is no config section for the symbol 64_BIT, so !64_BIT will 
always be evaluated to true, and therefore RAMSTER will always select 
HAVE_ALIGNED_STRUCT_PAGE, disregarding any breakage.

64_BIT should probably say 64BIT which has corresponding config sections in 
arch/{x86,ia64,mips,s390,tile,alpha,arm64,sparc,parisc,powerpc}/Kconfig and 
arch/x86/um/Kconfig.

I do not know if there are any bad consequences about this, but I guess this 
should be reviewed and fixed, probably by just removing the underscore from 
64_BIT in drivers/staging/zcache/Kconfig.

Regards
Martin Walch
-- 

--nextPart5173705.3zXMljTsZa
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iEYEABECAAYFAlFEyZ8ACgkQM6S4K8IXn9dATQCgjLCemlSYDUbSIKUmPXeN35Oz
5UoAoLUkQ+m6wKO7K2yyG9xgl/qaS8Oj
=UC0L
-----END PGP SIGNATURE-----

--nextPart5173705.3zXMljTsZa--

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/