Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756246Ab3CQNiv (ORCPT ); Sun, 17 Mar 2013 09:38:51 -0400 Received: from mail-wg0-f54.google.com ([74.125.82.54]:33498 "EHLO mail-wg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756197Ab3CQNii (ORCPT ); Sun, 17 Mar 2013 09:38:38 -0400 MIME-Version: 1.0 In-Reply-To: <1363506232-11517-1-git-send-email-silviupopescu1990@gmail.com> References: <1363506232-11517-1-git-send-email-silviupopescu1990@gmail.com> From: Prabhakar Lad Date: Sun, 17 Mar 2013 19:08:16 +0530 Message-ID: Subject: Re: [PATCH] drivers: staging: davinci_vpfe: use resource_size() To: Silviu-Mihai Popescu Cc: linux-media@vger.kernel.org, gregkh@linuxfoundation.org, Sakari Ailus , Laurent Pinchart , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, dlos Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4071 Lines: 105 Hi, Thanks for the patch! On Sun, Mar 17, 2013 at 1:13 PM, Silviu-Mihai Popescu wrote: > This uses the resource_size() function instead of explicit computation. > > Signed-off-by: Silviu-Mihai Popescu > --- > drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 3 ++- > drivers/staging/media/davinci_vpfe/dm365_isif.c | 6 ++++-- > drivers/staging/media/davinci_vpfe/dm365_resizer.c | 4 +++- > 3 files changed, 9 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c > index 9285353..de3f202 100644 > --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c > +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c > @@ -27,6 +27,7 @@ > */ > > #include > +#include > > #include "dm365_ipipe.h" > #include "dm365_ipipe_hw.h" > @@ -1859,5 +1860,5 @@ void vpfe_ipipe_cleanup(struct vpfe_ipipe_device *ipipe, > iounmap(ipipe->isp5_base_addr); > res = platform_get_resource(pdev, IORESOURCE_MEM, 4); > if (res) > - release_mem_region(res->start, res->end - res->start + 1); > + release_mem_region(res->start, resource_size(res)); > } > diff --git a/drivers/staging/media/davinci_vpfe/dm365_isif.c b/drivers/staging/media/davinci_vpfe/dm365_isif.c > index ebeea72..cd263d5 100644 > --- a/drivers/staging/media/davinci_vpfe/dm365_isif.c > +++ b/drivers/staging/media/davinci_vpfe/dm365_isif.c > @@ -19,6 +19,8 @@ > * Prabhakar Lad > */ > > +#include > + > #include "dm365_isif.h" > #include "vpfe_mc_capture.h" > > @@ -1953,7 +1955,7 @@ static void isif_remove(struct vpfe_isif_device *isif, > res = platform_get_resource(pdev, IORESOURCE_MEM, i); > if (res) > release_mem_region(res->start, > - res->end - res->start + 1); > + resource_size(res)); > i++; > } > } > @@ -2003,7 +2005,7 @@ int vpfe_isif_init(struct vpfe_isif_device *isif, struct platform_device *pdev) > status = -ENOENT; > goto fail_nobase_res; > } > - res_len = res->end - res->start + 1; > + res_len = resource_size(res); > res = request_mem_region(res->start, res_len, res->name); > if (!res) { > status = -EBUSY; > diff --git a/drivers/staging/media/davinci_vpfe/dm365_resizer.c b/drivers/staging/media/davinci_vpfe/dm365_resizer.c > index 9cb0262..c351ea1 100644 > --- a/drivers/staging/media/davinci_vpfe/dm365_resizer.c > +++ b/drivers/staging/media/davinci_vpfe/dm365_resizer.c > @@ -24,6 +24,8 @@ > * same input image, but can have different output resolution. > */ > > +#include > + did you build test this patch ? the above header file(ioport.h) is not required in all the above files which you included. Cheers, --Prabhakar Lad http://in.linkedin.com/pub/prabhakar-lad/19/92b/955 > #include "dm365_ipipe_hw.h" > #include "dm365_resizer.h" > > @@ -1995,5 +1997,5 @@ vpfe_resizer_cleanup(struct vpfe_resizer_device *vpfe_rsz, > res = platform_get_resource(pdev, IORESOURCE_MEM, 5); > if (res) > release_mem_region(res->start, > - res->end - res->start + 1); > + resource_size(res)); > } > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/