Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932763Ab3CQOz7 (ORCPT ); Sun, 17 Mar 2013 10:55:59 -0400 Received: from mga03.intel.com ([143.182.124.21]:12605 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932681Ab3CQOzz (ORCPT ); Sun, 17 Mar 2013 10:55:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,859,1355126400"; d="scan'208";a="272000059" From: Andi Kleen To: Mel Gorman Cc: Linux-MM , Jiri Slaby , Valdis Kletnieks , Rik van Riel , Zlatko Calusic , Johannes Weiner , dormando , Satoru Moriya , Michal Hocko , LKML Subject: Re: [PATCH 10/10] mm: vmscan: Move logic from balance_pgdat() to kswapd_shrink_zone() References: <1363525456-10448-1-git-send-email-mgorman@suse.de> <1363525456-10448-11-git-send-email-mgorman@suse.de> Date: Sun, 17 Mar 2013 07:55:54 -0700 In-Reply-To: <1363525456-10448-11-git-send-email-mgorman@suse.de> (Mel Gorman's message of "Sun, 17 Mar 2013 13:04:16 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 892 Lines: 24 Mel Gorman writes: > + > + /* > + * We put equal pressure on every zone, unless one zone has way too > + * many pages free already. The "too many pages" is defined as the > + * high wmark plus a "gap" where the gap is either the low > + * watermark or 1% of the zone, whichever is smaller. > + */ > + balance_gap = min(low_wmark_pages(zone), > + (zone->managed_pages + KSWAPD_ZONE_BALANCE_GAP_RATIO-1) / > + KSWAPD_ZONE_BALANCE_GAP_RATIO); Don't like those hard coded tunables. 1% of a 512GB node can be still quite a lot. Shouldn't the low watermark be enough? -Andi -- ak@linux.intel.com -- Speaking for myself only -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/